deps: define V8_PRESERVE_MOST as no-op on Windows #56238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's causing linker errors with node.lib in node-gyp and potentially breaks other 3rd party tools
StefanStojanovic
added
windows
|
Review requested:
|
nodejs-github-bot
added
build
targos
approved these changes
Dec 12, 2024
StefanStojanovic
added
the
request-ci
github-actions
bot
removed
the
request-ci
jasnell
approved these changes
Dec 12, 2024
anonrig
approved these changes
Dec 13, 2024
lpinca
approved these changes
Dec 13, 2024
StefanStojanovic
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in b171afe |
aduh95
pushed a commit
that referenced
this pull request
Dec 18, 2024
It's causing linker errors with node.lib in node-gyp and potentially breaks other 3rd party tools PR-URL: #56238 Refs: #55784 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Dec 18, 2024
It's causing linker errors with node.lib in node-gyp and potentially breaks other 3rd party tools PR-URL: #56238 Refs: #55784 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
to targos/node
that referenced
this pull request
Dec 19, 2024
It's causing linker errors with node.lib in node-gyp and potentially breaks other 3rd party tools PR-URL: nodejs#56238 Refs: nodejs#55784 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling with ClangCL, it's causing linker errors with node.lib in node-gyp and potentially breaks other 3rd party tools.
This was already reviewed in another PR where it was grouped with other changes. Here is the part of the description from that PR regarding this change:
Disable V8_PRESERVE_MOST on Windows. We already have something similar for V8_NODISCARD as a floating patch, so it should not be a problem as I see it. If left, this results in functions that use it having
__swift_2calling conventions rather than the expected__cdecl. This was noticed incppgc-objectnative suites test. This change, if agreed upon, would be come one of our V8 floating patches we use on each V8 update.Refs: #55784