Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: add release line label when opening release proposal #56317

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Dec 19, 2024

I had to add it manually in #56310 (comment), let's have the automation do it for us.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Dec 19, 2024
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but usually the pr-labeler action adds it automatically

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 19, 2024
@aduh95
Copy link
Contributor Author

aduh95 commented Dec 19, 2024

usually the pr-labeler action adds it automatically

The pr-labeler action doesn't run on PR opens with another workflow token (which is what we want in this case as we open the PR before pushing the release commit)

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 21, 2024
@nodejs-github-bot nodejs-github-bot merged commit 821ab6f into nodejs:main Dec 21, 2024
31 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 821ab6f

@aduh95 aduh95 deleted the release-proposal-label branch December 21, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants