-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix invalid path doc comments #5670
Conversation
I think the goal was to get syntax highlighting for what was returned. I find it more readable the way that it currently is... |
/cc @nodejs/documentation |
LGTM although I'm +0 on this, not sure this makes things better. |
I would go for consistency throughout the docs over personal preference here. ATM it seems we mix two styles: In buffer.markdown and http.markdown// returns: true In path.markdown and querystring.markdown// returns
true I'm +1 on landing this if we do the same change for querystring - might be a separate PR of course. Otherwise buffer and http should be changed. And multiline results should be commented with |
LGTM |
LGTM |
The format of certain code comments in the `path` documentation results in the code blocks being invalid. I also find it confusing at least as formatted on the website. This change is intended to improve those comments.
Rebased, made that change, force pushed. |
Still LGTM |
There are some LGTM's but also at least one (mild?) preference for the current formatting. I see no strong objections. I'll land this in 24 hours or so unless either a collaborator indicates they'd strongly prefer this not land, or unless there is a significant pile-up of milder objections from collaborators (let's say two more people). |
The format of certain code comments in the `path` documentation results in the code blocks being invalid. I also find it confusing at least as formatted on the website. This change is intended to improve those comments. PR-URL: nodejs#5670 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Landed in 9eb0ef4 |
@Trott this is going to need some manual backporting love |
@thealphanerd Sure: #5797 |
The format of certain code comments in the `path` documentation results in the code blocks being invalid. I also find it confusing at least as formatted on the website. This change is intended to improve those comments. PR-URL: #5670 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Conflicts: doc/api/path.markdown
Affected core subsystem(s)
doc, path
Description of change
The format of certain code comments in the
path
documentation resultsin the code blocks being invalid. I also find it confusing at least as
formatted on the website. This change is intended to improve those
comments.