Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix invalid path doc comments #5670

Closed
wants to merge 1 commit into from
Closed

doc: fix invalid path doc comments #5670

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 12, 2016

Affected core subsystem(s)

doc, path

Description of change

The format of certain code comments in the path documentation results
in the code blocks being invalid. I also find it confusing at least as
formatted on the website. This change is intended to improve those
comments.

@Trott Trott added doc Issues and PRs related to the documentations. path Issues and PRs related to the path subsystem. lts-watch-v4.x labels Mar 12, 2016
@evanlucas
Copy link
Contributor

I think the goal was to get syntax highlighting for what was returned. I find it more readable the way that it currently is...

@Trott
Copy link
Member Author

Trott commented Mar 12, 2016

/cc @nodejs/documentation

@benjamingr
Copy link
Member

LGTM although I'm +0 on this, not sure this makes things better.

@phillipj
Copy link
Member

I would go for consistency throughout the docs over personal preference here. ATM it seems we mix two styles:

In buffer.markdown and http.markdown
// returns: true
In path.markdown and querystring.markdown
// returns
true

I'm +1 on landing this if we do the same change for querystring - might be a separate PR of course. Otherwise buffer and http should be changed.

And multiline results should be commented with // rather than /* .. */ as the former is used for documenting multiline console output in most cases.

@jasnell
Copy link
Member

jasnell commented Mar 14, 2016

LGTM

@mscdex
Copy link
Contributor

mscdex commented Mar 14, 2016

LGTM

The format of certain code comments in the `path` documentation results
in the code blocks being invalid. I also find it confusing at least as
formatted on the website. This change is intended to improve those
comments.
@Trott
Copy link
Member Author

Trott commented Mar 14, 2016

And multiline results should be commented with // rather than /* .. */ as the former is used for documenting multiline console output in most cases.

Rebased, made that change, force pushed.

@jasnell
Copy link
Member

jasnell commented Mar 15, 2016

Still LGTM

@Trott
Copy link
Member Author

Trott commented Mar 16, 2016

There are some LGTM's but also at least one (mild?) preference for the current formatting. I see no strong objections. I'll land this in 24 hours or so unless either a collaborator indicates they'd strongly prefer this not land, or unless there is a significant pile-up of milder objections from collaborators (let's say two more people).

Trott added a commit to Trott/io.js that referenced this pull request Mar 17, 2016
The format of certain code comments in the `path` documentation results
in the code blocks being invalid. I also find it confusing at least as
formatted on the website. This change is intended to improve those
comments.

PR-URL: nodejs#5670
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@Trott
Copy link
Member Author

Trott commented Mar 17, 2016

Landed in 9eb0ef4

@Trott Trott closed this Mar 17, 2016
@MylesBorins
Copy link
Contributor

@Trott this is going to need some manual backporting love

@Trott
Copy link
Member Author

Trott commented Mar 19, 2016

@thealphanerd Sure: #5797

Fishrock123 pushed a commit that referenced this pull request Mar 22, 2016
The format of certain code comments in the `path` documentation results
in the code blocks being invalid. I also find it confusing at least as
formatted on the website. This change is intended to improve those
comments.

PR-URL: #5670
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>

Conflicts:
	doc/api/path.markdown
@Trott Trott deleted the mud branch January 13, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. path Issues and PRs related to the path subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants