Backport of 5528 #5785
Closed
Backport of 5528 #5785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a known_issues directory to the test directory for scripts that reproduce known bugs. Since these scripts are expected to fail, it also adds a --expect-fail flag to test.py which reports tests as successful when they fail. Refs: nodejs/testing#18 PR-URL: nodejs#5528 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Conflicts: tools/test.py
This commit adds a failing test case for the vm module. Currently, if runInContext() defines a function, and a later call to runInContext() redefines the same function, the original function is not overwritten. Refs: nodejs#548 PR-URL: nodejs#5528 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
4 tasks
|
LGTM if ci is green |
|
LGTM. Unrelated test failure on ARM. How are we going to test this on the CI? EDIT: By which I mean: how are we going to test the new Makefile target on the CI? |
|
Don't want to hijack the comment thread here, but the flaky ARM failure above is fixed in #5728 but that PR still needs a LGTM from a collaborator. Feel free to review! |
|
@joaocgreis would it be possible to get a CI job setup to run this, independent of any other jobs? |
|
@cjihrig An alternative to getting a custom CI job could be to create a new branch from this one, change |
|
@Trott that does not work for the I created a new job (slow, no cross-compiling), here is the first run: https://ci.nodejs.org/job/node-test-known-issues/1/ . There seems to be something wrong with one |
|
Thanks @joaocgreis! |
|
LGTM |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
This commit adds a known_issues directory to the test directory for scripts that reproduce known bugs. Since these scripts are expected to fail, it also adds a --expect-fail flag to test.py which reports tests as successful when they fail. Refs: nodejs/testing#18 Backport-URL: #5785 PR-URL: #5528 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Conflicts: tools/test.py
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
This commit adds a failing test case for the vm module. Currently, if runInContext() defines a function, and a later call to runInContext() redefines the same function, the original function is not overwritten. Refs: #548 Backport-URL: #5785 PR-URL: #5528 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
|
landed in 52e2141...7725cd3 |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
This commit adds a known_issues directory to the test directory for scripts that reproduce known bugs. Since these scripts are expected to fail, it also adds a --expect-fail flag to test.py which reports tests as successful when they fail. Refs: nodejs/testing#18 Backport-URL: #5785 PR-URL: #5528 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Conflicts: tools/test.py
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
This commit adds a failing test case for the vm module. Currently, if runInContext() defines a function, and a later call to runInContext() redefines the same function, the original function is not overwritten. Refs: #548 Backport-URL: #5785 PR-URL: #5528 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
This commit adds a known_issues directory to the test directory for scripts that reproduce known bugs. Since these scripts are expected to fail, it also adds a --expect-fail flag to test.py which reports tests as successful when they fail. Refs: nodejs/testing#18 Backport-URL: #5785 PR-URL: #5528 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Conflicts: tools/test.py
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
This commit adds a failing test case for the vm module. Currently, if runInContext() defines a function, and a later call to runInContext() redefines the same function, the original function is not overwritten. Refs: #548 Backport-URL: #5785 PR-URL: #5528 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #5528 (test: add a place for reproducing known bugs) to the v4.x-staging branch, at @thealphanerd request.