Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dns: use isIp consistently #5804

Closed
wants to merge 1 commit into from
Closed

dns: use isIp consistently #5804

wants to merge 1 commit into from

Commits on Mar 19, 2016

  1. dns: use isIp consistently 

    Currently the DNS module imports isIP from both cares and `net` and
uses both of them both throughout the code base. This PR removes the
direct dependency `dns` has on `net` and uses `isIp` from c-ares all
the time. Note that both functions do the same thing.

PR-URL:
Reviewed-By:
Reviewed-By:
    @benjamingr
    benjamingr committed Mar 19, 2016
    Configuration menu
    Copy the full SHA
    65acb8d View commit details
    Browse the repository at this point in the history