-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix test-cluster-worker-kill
#5814
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGTM |
Don't check that the `disconnect` event is emitted before the `exit` event as the order is not guaranteed.
santigimeno
force-pushed
the
fix-cluster-worker-kill
branch
from
March 20, 2016 20:47
b43d365
to
5dae734
Compare
mscdex
added
cluster
Issues and PRs related to the cluster subsystem.
test
Issues and PRs related to the tests.
labels
Mar 20, 2016
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Mar 21, 2016
Don't check that the `disconnect` event is emitted before the `exit` event as the order is not guaranteed. PR-URL: #5814 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Landed in 8d39481 |
Fishrock123
pushed a commit
that referenced
this pull request
Mar 22, 2016
Don't check that the `disconnect` event is emitted before the `exit` event as the order is not guaranteed. PR-URL: #5814 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 30, 2016
Don't check that the `disconnect` event is emitted before the `exit` event as the order is not guaranteed. PR-URL: #5814 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 30, 2016
Don't check that the `disconnect` event is emitted before the `exit` event as the order is not guaranteed. PR-URL: #5814 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
jBarz
added a commit
to ibmruntimes/node
that referenced
this pull request
Feb 19, 2017
cherry-pick following from master commit 8d39481 Author: Santiago Gimeno <santiago.gimeno@gmail.com> Date: Sun Mar 20 21:11:36 2016 +0100 test: fix `test-cluster-worker-kill` Don't check that the `disconnect` event is emitted before the `exit` event as the order is not guaranteed. PR-URL: nodejs/node#5814 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
make -j8 test
(UNIX) orvcbuild test nosign
(Windows) pass withthis change (including linting)?
Affected core subsystem(s)
test
Description of change
Don't check that the
disconnect
event is emitted before theexit
event as the order is not guaranteed.
See failing test @ https://ci.nodejs.org/job/node-test-commit-linux/nodes=centos5-32/2648/tapTestReport/test.tap-133/