Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: updated fs #5862 #5869

Closed
wants to merge 2 commits into from
Closed

doc: updated fs #5862 #5869

wants to merge 2 commits into from

Conversation

ToPal
Copy link

@ToPal ToPal commented Mar 23, 2016

See issue #5862.
Removed irrelevant data about fs.readFile in docs for version 4.x

nodejs#5862 
removed irrelevant data about fs.readFile
@mscdex mscdex added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Mar 23, 2016
@mscdex
Copy link
Contributor

mscdex commented Mar 23, 2016

I'm not sure if it was intentional that file descriptors are not working with fs.readFile(), but assuming it was intentional, there are a couple of other comments at the end of the fs.readFile() section there that need to be removed also.

@jasnell
Copy link
Member

jasnell commented Mar 23, 2016

@ToPal ... thanks for this. Since this is for v4.x, the PR actually needs to be opened against the v4.x-staging branch instead of directly against v4.x. We land all changes into the staging branch first and only pull things into v4.x when there's a release.

removed irrelevant data about fs.readFile
@ToPal
Copy link
Author

ToPal commented Mar 23, 2016

Thanks, @mscdex! I fixed it.

@ToPal
Copy link
Author

ToPal commented Mar 23, 2016

@jasnell Thank you for information! I've created a new pull request for branch v4.x-staging.

@ToPal ToPal closed this Mar 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants