Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: ensure win32.isAbsolute() is consistent #6043

Closed
wants to merge 1 commit into from
Closed

test: ensure win32.isAbsolute() is consistent #6043

wants to merge 1 commit into from

Conversation

MylesBorins
Copy link
Contributor

Adds test cases to ensure win32.isAbsolute is consistent.

This is a backport from 3072546

ref: #6028

@mscdex
test: ensure win32.isAbsolute() is consistent
809f930 
Adds test cases to ensure win32.isAbsolute is consistent.

This is a backport from 3072546

ref: nodejs#6028
@mscdex mscdex added test Issues and PRs related to the tests. path Issues and PRs related to the path subsystem. v4.x labels Apr 4, 2016
@MylesBorins
Copy link
Contributor Author

ci: https://ci.nodejs.org/job/node-test-pull-request/2156/

@MylesBorins
Copy link
Contributor Author

@mscdex I kept you as the author of the commit although I have completely rewritten the commit title / message. Please let me know if you would like anything changed, including your authorship.

@jasnell
Copy link
Member

jasnell commented Apr 4, 2016

LGTM if CI is green

@mscdex
Copy link
Contributor

mscdex commented Apr 4, 2016

LGTM

@mscdex mscdex removed their assignment Apr 4, 2016
@silverwind
Copy link
Contributor

LGTM

jasnell pushed a commit that referenced this pull request Apr 8, 2016
@mscdex @jasnell
test: ensure win32.isAbsolute() is consistent
ea83c38 
Adds test cases to ensure win32.isAbsolute is consistent.

This is a backport from 3072546

Refs: #6028
PR-URL: #6043
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Roman Reiss <me@silverwind.io>
@jasnell
Copy link
Member

jasnell commented Apr 8, 2016

Landed in v4.x-staging in ea83c38

@jasnell jasnell closed this Apr 8, 2016
@MylesBorins
Copy link
Contributor Author

thanks @jasnell

@MylesBorins MylesBorins mentioned this pull request Apr 11, 2016
Merged
@MylesBorins MylesBorins deleted the path-win32 branch April 16, 2016 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
path Issues and PRs related to the path subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MylesBorins @jasnell @mscdex @silverwind