Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: enforce strict mode for test-domain-crypto #6047

Closed
wants to merge 1 commit into from
Closed

test: enforce strict mode for test-domain-crypto #6047

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 4, 2016

Pull Request check-list

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to [CONTRIBUTING.md][0]?

Affected core subsystem(s)

crypto domain test

Description of change

The last change to this test landed before a nit about strict mode was
addressed, so this change addresses that.

Refs: #6017

/cc @bnoordhuis @jasnell

@Trott
test: enforce strict mode for test-domain-crypto
c15a6be 
The last change to this test landed before a nit about strict mode was
addressed, so this change addresses that.

Refs: nodejs#6017
@Trott Trott added crypto Issues and PRs related to the crypto subsystem. domain Issues and PRs related to the domain subsystem. test Issues and PRs related to the tests. lts-watch-v4.x labels Apr 4, 2016
@cjihrig
Copy link
Contributor

cjihrig commented Apr 5, 2016

LGTM

2 similar comments
@benjamingr
Copy link
Member

LGTM

@r-52
Copy link
Contributor

r-52 commented Apr 5, 2016

LGTM

@Trott
Copy link
Member Author

Trott commented Apr 5, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/2162/

Trott added a commit to Trott/io.js that referenced this pull request Apr 6, 2016
@Trott
test: enforce strict mode for test-domain-crypto
d4eafd0 
The last change to this test landed before a nit about strict mode was
addressed, so this change addresses that.

PR-URL: nodejs#6047
Refs: nodejs#6017
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
@Trott
Copy link
Member Author

Trott commented Apr 6, 2016

Landed in d4eafd0

@Trott Trott closed this Apr 6, 2016
MylesBorins pushed a commit that referenced this pull request Apr 19, 2016
@Trott
test: enforce strict mode for test-domain-crypto
473ffdc 
The last change to this test landed before a nit about strict mode was
addressed, so this change addresses that.

PR-URL: #6047
Refs: #6017
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
@Trott
test: enforce strict mode for test-domain-crypto
8ab2d73 
The last change to this test landed before a nit about strict mode was
addressed, so this change addresses that.

PR-URL: #6047
Refs: #6017
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 20, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
@Trott
test: enforce strict mode for test-domain-crypto
a27e952 
The last change to this test landed before a nit about strict mode was
addressed, so this change addresses that.

PR-URL: #6047
Refs: #6017
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
This was referenced Apr 21, 2016
Closed
Closed
MylesBorins pushed a commit that referenced this pull request May 17, 2016
@Trott
test: enforce strict mode for test-domain-crypto
fb6bd9e 
The last change to this test landed before a nit about strict mode was
addressed, so this change addresses that.

PR-URL: #6047
Refs: #6017
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 18, 2016
@Trott
test: enforce strict mode for test-domain-crypto
3a67a05 
The last change to this test landed before a nit about strict mode was
addressed, so this change addresses that.

PR-URL: #6047
Refs: #6017
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 18, 2016
Merged
@Trott Trott deleted the strict branch July 31, 2018 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
crypto Issues and PRs related to the crypto subsystem. domain Issues and PRs related to the domain subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @cjihrig @benjamingr @r-52 @MylesBorins