Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix broken references #6100

Closed
wants to merge 1 commit into from
Closed

doc: fix broken references #6100

wants to merge 1 commit into from

Conversation

gromnitsky
Copy link
Contributor

@gromnitsky gromnitsky commented Apr 7, 2016

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Fix multiple broken cross-references.

@Fishrock123 Fishrock123 added the doc Issues and PRs related to the documentations. label Apr 7, 2016
@MylesBorins
Copy link
Contributor

/cc @nodejs/documentation I think we should consider some sort of docs CI that can build / host the docs. Reviewing a change like this would be much faster if all we had to do is click a link.

@jasnell
Copy link
Member

jasnell commented Apr 7, 2016

LGTM and +1 to @thealphanerd's suggestion

@Knighton910
Copy link

+1

jasnell pushed a commit that referenced this pull request Apr 18, 2016
PR-URL: #6100
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Apr 18, 2016

Landed in 3641ca9

@jasnell jasnell closed this Apr 18, 2016
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
PR-URL: #6100
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 20, 2016
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
PR-URL: #6100
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 21, 2016
PR-URL: #6100
Reviewed-By: James M Snell <jasnell@gmail.com>
@gromnitsky gromnitsky deleted the doc-ref-fix branch April 22, 2016 19:18
joelostrowski pushed a commit to joelostrowski/node that referenced this pull request Apr 25, 2016
PR-URL: nodejs#6100
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request Apr 26, 2016
PR-URL: #6100
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins
Copy link
Contributor

If this is going to be backported I would like it to be done so manually to make sure we do not accidentally change information in the lts docs

@MylesBorins
Copy link
Contributor

adding don't land for now. If anyone would like to backport please open a pull request targeting v4.x-staging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants