Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky test-child-process-fork-net #6138

Closed
wants to merge 1 commit into from
Closed

test: fix flaky test-child-process-fork-net #6138

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 10, 2016

Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

test, child_process, arm

Description of change

Reduce client connections from 10 to 4 in a test that is causing issues
on Raspberry Pi 2 devices in CI.

Fixes: #5122

@Trott
test: fix flaky test-child-process-fork-net
e8ca991 
Reduce client connections from 10 to 4 in a test that is causing issues
on Raspberry Pi 2 devices in CI.

Fixes: nodejs#5122
@Trott Trott added child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests. arm Issues and PRs related to the ARM platform. labels Apr 10, 2016
@Trott Trott mentioned this pull request Apr 10, 2016
Closed
@Trott
Copy link
Member Author

Trott commented Apr 10, 2016

Stress test against current master to show failure: https://ci.nodejs.org/job/node-stress-single-test/588/nodes=pi2-raspbian-wheezy/console

Stress test with this proposed change to show success: https://ci.nodejs.org/job/node-stress-single-test/590/nodes=pi2-raspbian-wheezy/console

@benjamingr
Copy link
Member

LGTM - why was it 10 to begin with?

@Trott
Copy link
Member Author

Trott commented Apr 10, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/2237/

Trott added a commit to Trott/io.js that referenced this pull request Apr 12, 2016
@Trott
test: fix flaky test-child-process-fork-net
aba035f 
Reduce client connections from 10 to 4 in a test that is causing issues
on Raspberry Pi 2 devices in CI.

Fixes: nodejs#5122
PR-URL: nodejs#6138
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@Trott
Copy link
Member Author

Trott commented Apr 12, 2016

Landed in aba035f

@Trott Trott closed this Apr 12, 2016
MylesBorins pushed a commit that referenced this pull request Apr 19, 2016
@Trott
test: fix flaky test-child-process-fork-net
ea828ce 
Reduce client connections from 10 to 4 in a test that is causing issues
on Raspberry Pi 2 devices in CI.

Fixes: #5122
PR-URL: #6138
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
@Trott
test: fix flaky test-child-process-fork-net
1b8dad2 
Reduce client connections from 10 to 4 in a test that is causing issues
on Raspberry Pi 2 devices in CI.

Fixes: #5122
PR-URL: #6138
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 20, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
@Trott
test: fix flaky test-child-process-fork-net
a38b614 
Reduce client connections from 10 to 4 in a test that is causing issues
on Raspberry Pi 2 devices in CI.

Fixes: #5122
PR-URL: #6138
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This was referenced Apr 21, 2016
Closed
Closed
Closed
@MylesBorins
Copy link
Contributor

@Trott lts?

@Trott
Copy link
Member Author

Trott commented Apr 21, 2016

@thealphanerd Yes, if it lands cleanly.

jasnell pushed a commit that referenced this pull request Apr 26, 2016
@Trott @jasnell
test: fix flaky test-child-process-fork-net
5a26849 
Reduce client connections from 10 to 4 in a test that is causing issues
on Raspberry Pi 2 devices in CI.

Fixes: #5122
PR-URL: #6138
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 17, 2016
@Trott
test: fix flaky test-child-process-fork-net
4593721 
Reduce client connections from 10 to 4 in a test that is causing issues
on Raspberry Pi 2 devices in CI.

Fixes: #5122
PR-URL: #6138
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 18, 2016
@Trott
test: fix flaky test-child-process-fork-net
69dcbb6 
Reduce client connections from 10 to 4 in a test that is causing issues
on Raspberry Pi 2 devices in CI.

Fixes: #5122
PR-URL: #6138
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 18, 2016
Merged
@Trott Trott deleted the white branch January 13, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
arm Issues and PRs related to the ARM platform. child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate flaky test-child-process-fork-net
3 participants
@Trott @benjamingr @MylesBorins