Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repl: Don’t complete non-simple expressions #6192

Closed
wants to merge 1 commit into from
Closed

repl: Don’t complete non-simple expressions #6192

wants to merge 1 commit into from

Commits on Apr 14, 2016

  1. repl: Don’t complete non-simple expressions 

    Change the regular expression that recognizes “simple” JS expressions
to requiring that the full line needs to match it.

Previously, in terms like `a().b.`, `b.` would be a partial match.
This meant that completion would evaluate `b` and either fail with
a `ReferenceError` or, if `b` was some global, return the properties
of the global `b` object.
    @addaleax
    addaleax committed Apr 14, 2016
    Configuration menu
    Copy the full SHA
    07234eb View commit details
    Browse the repository at this point in the history