Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Add addaleax to collaborators #6224

Closed
wants to merge 1 commit into from
Closed

doc: Add addaleax to collaborators #6224

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Add myself :)

@jasnell
Copy link
Member

jasnell commented Apr 15, 2016

+1 LGTM! /cc @Fishrock123

@jasnell jasnell added the meta Issues and PRs related to the general management of the project. label Apr 15, 2016
@addaleax addaleax force-pushed the add-addaleax-to-collaborators branch from e1205da to 15e3998 Compare April 15, 2016 17:34
@evanlucas
Copy link
Contributor

LGTM

Trott
Trott reviewed Apr 15, 2016
View reviewed changes
README.md
@@ -168,6 +168,7 @@ information about the governance of the Node.js project, see
### Collaborators

* [AndreasMadsen](https://github.com/AndreasMadsen) - **Andreas Madsen** <amwebdk@gmail.com>
* [addaleax](https://github.com/addaleax) - **Anna Henningsen** <anna@addaleax.net>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alphabetize by username. Thanks!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

… updated. 😄

@Trott
Copy link
Member

Trott commented Apr 15, 2016

LGTM with nit.

@addaleax addaleax force-pushed the add-addaleax-to-collaborators branch from 15e3998 to 7009bfd Compare April 15, 2016 17:35
@bnoordhuis
Copy link
Member

LGTM and welcome aboard, Anna.

@Trott
Copy link
Member

Trott commented Apr 15, 2016

LGTM!

:shipit:

@MylesBorins
Copy link
Contributor

LGTM... well deserved

🎉

addaleax added a commit that referenced this pull request Apr 15, 2016
@addaleax
doc: add addaleax to collaborators
69040d6 
PR-URL: #6224
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@addaleax
Copy link
Member Author

Landed in 69040d6! 🎉

@addaleax addaleax closed this Apr 15, 2016
@addaleax addaleax deleted the add-addaleax-to-collaborators branch April 15, 2016 17:44
@Fishrock123
Copy link
Contributor

🎉 🎉 🎉

@santigimeno
Copy link
Member

Welcome!

MylesBorins pushed a commit that referenced this pull request Apr 19, 2016
@addaleax
doc: add addaleax to collaborators
5c40fc1 
PR-URL: #6224
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
@addaleax
doc: add addaleax to collaborators
bbd990f 
PR-URL: #6224
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
@addaleax
doc: add addaleax to collaborators
93ff5de 
PR-URL: #6224
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 20, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
@addaleax
doc: add addaleax to collaborators
976e4bb 
PR-URL: #6224
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
This was referenced Apr 21, 2016
Closed
Closed
Closed
MylesBorins pushed a commit that referenced this pull request Apr 21, 2016
@addaleax @MylesBorins
doc: add addaleax to collaborators
1427a5b 
PR-URL: #6224
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 21, 2016
@addaleax @MylesBorins
doc: add addaleax to collaborators
3364703 
PR-URL: #6224
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
joelostrowski pushed a commit to joelostrowski/node that referenced this pull request Apr 25, 2016
@addaleax @joelostrowski
doc: add addaleax to collaborators
41ab1f2 
PR-URL: nodejs#6224
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
jasnell pushed a commit that referenced this pull request Apr 26, 2016
@addaleax @jasnell
doc: add addaleax to collaborators
8b5acd5 
PR-URL: #6224
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jun 1, 2016
@addaleax
doc: add addaleax to collaborators
a856545 
PR-URL: #6224
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jun 24, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
@addaleax
doc: add addaleax to collaborators
ae3eb24 
PR-URL: #6224
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
@addaleax
doc: add addaleax to collaborators
7a3c608 
PR-URL: #6224
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@addaleax @jasnell @evanlucas @Trott @bnoordhuis @MylesBorins @Fishrock123 @santigimeno