Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Google Analytics to doc pages. #6462

Closed
wants to merge 1 commit into from
Closed

Adding Google Analytics to doc pages. #6462

wants to merge 1 commit into from

Conversation

mikeal
Copy link
Contributor

@mikeal mikeal commented Apr 29, 2016

This adds the same analytics line to our documentation as we have on the rest of the website.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 29, 2016
@evanlucas
Copy link
Contributor

do we care that this will be executed when run locally?

@jasnell
Copy link
Member

jasnell commented Apr 29, 2016

hmm.. fwiw, I care that this would be executed when run locally. Couldn't this be injected only when the docs are on the website. -1 on this being here.

@mikeal
Copy link
Contributor Author

mikeal commented Apr 29, 2016

Good point, pinging @nodejs/build to see if we can get this worked into that process.

@jbergstroem
Copy link
Member

jbergstroem commented Apr 29, 2016

SSI?

Edit: would work like so:

<!--# include file="tracking.html" -->

@jasnell
Copy link
Member

jasnell commented May 1, 2016

Given the -1's can we close this and defer the discussion over to the nodejs/nodejs.org repo?

@jbergstroem
Copy link
Member

@jasnell doesn't seem to be an open issue there. Want to create one?

@jbergstroem
Copy link
Member

We could use the sub module as well, but I'd like to do some performance measuring first seeing how we push 500mbit/sec+.

@jasnell
Copy link
Member

jasnell commented May 1, 2016

Done: nodejs/nodejs.org#709

@jbergstroem
Copy link
Member

Lets close it and continue over there then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants