-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Google Analytics to doc pages. #6462
Conversation
do we care that this will be executed when run locally? |
hmm.. fwiw, I care that this would be executed when run locally. Couldn't this be injected only when the docs are on the website. -1 on this being here. |
Good point, pinging @nodejs/build to see if we can get this worked into that process. |
SSI? Edit: would work like so: <!--# include file="tracking.html" --> |
Given the -1's can we close this and defer the discussion over to the nodejs/nodejs.org repo? |
@jasnell doesn't seem to be an open issue there. Want to create one? |
We could use the sub module as well, but I'd like to do some performance measuring first seeing how we push 500mbit/sec+. |
Done: nodejs/nodejs.org#709 |
Lets close it and continue over there then. |
This adds the same analytics line to our documentation as we have on the rest of the website.