doc: fix incorrect syntax in examples #6463
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -305,7 +305,7 @@ this value. | |||
| ```js | |||
| cluster.on('exit', (worker, code, signal) => { | |||
| if (worker.exitedAfterDisconnect === true) { | |||
| console.log('Oh, it was just voluntary\' – no need to worry'). | |||
| console.log('Oh, it was just voluntary\' – no need to worry'); | |||
There was a problem hiding this comment.
can drop the \' in the middle too
|
LGTM with a nit |
The cluster docs had a period instead of a semicolon at the end of two lines.
|
LGTM |
2 similar comments
|
LGTM |
|
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Apr 30, 2016
The cluster docs had a period instead of a semicolon at the end of two lines. PR-URL: #6463 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Jackson Tian <shvyo1987@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in 4b0dda0 |
Fishrock123
pushed a commit
that referenced
this pull request
May 4, 2016
The cluster docs had a period instead of a semicolon at the end of two lines. PR-URL: #6463 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Jackson Tian <shvyo1987@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced May 4, 2016
joelostrowski
pushed a commit
to joelostrowski/node
that referenced
this pull request
May 4, 2016
The cluster docs had a period instead of a semicolon at the end of two lines. PR-URL: nodejs#6463 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Jackson Tian <shvyo1987@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
The cluster docs had a period instead of a semicolon at the end of two
lines.