Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add added: information for process #6589

Closed
wants to merge 1 commit into from
Closed

doc: add added: information for process #6589

wants to merge 1 commit into from

Conversation

bengl
Copy link
Member

@bengl bengl commented May 5, 2016 •
edited
Loading

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Added introduction version metadata in process.md.

Most of the information is gleaned from changelogs. The rest is inferred
from git history.

Omitted cpuUsage() since it's not yet in a release.

Also omitted the streams, events and signals, since I didn't really
think it made sense for those.

Ref: #6578

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 5, 2016
@jasnell
Copy link
Member

jasnell commented May 5, 2016

Woohoo! Glad to see this moving forward.

@addaleax addaleax added the process Issues and PRs related to the process subsystem. label May 5, 2016
@addaleax
Copy link
Member

addaleax commented May 5, 2016

Yep, great work! You may want to use something like Ref: https://github.com/nodejs/node/issues/6578 in your commit message instead of the last line, because github otherwise thinks this is a full fix for it.

process.send is missing, I looked it up and it seems to have been added in 26c5905 / v0.5.9.

Other than that, LGTM and thank you a lot for the work you put into this!

@sam-github sam-github mentioned this pull request May 5, 2016
Closed
36 tasks
@bengl bengl force-pushed the process_api_intros branch from 8686e0f to 3a3be8a Compare May 5, 2016 05:47
@bengl
Copy link
Member Author

bengl commented May 5, 2016

@addaleax Fixed commit message and added meta for send.

@jasnell
Copy link
Member

jasnell commented May 6, 2016

LGTM

1 similar comment
@Qard
Copy link
Member

Qard commented May 6, 2016

LGTM

estliberitas
estliberitas reviewed May 8, 2016
View reviewed changes
doc/api/process.md
@@ -499,12 +538,16 @@ modules in the ecosystem that are known to extend, modify, or entirely replace
the value of `process.config`.*

## process.connected
<!-- YAML
added: 0.7.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/0.7.2/v0.7.2/ just for consistency?

@estliberitas
Copy link
Contributor

estliberitas commented May 8, 2016 •
edited
Loading

LGTM with nits addressed

@bengl
doc: add added: information for process
f6950f4 
Most of the information is gleaned from changelogs. The rest is inferred
from git history.

Omitted cpuUsage() since it's not yet in a release.

Also omitted the streams, events and signals, since I didn't really
think it made sense for those.

Ref: nodejs#6578
@bengl bengl force-pushed the process_api_intros branch from 3a3be8a to f6950f4 Compare May 8, 2016 20:03
@bengl
Copy link
Member Author

bengl commented May 8, 2016

@estliberitas fixed

addaleax pushed a commit that referenced this pull request May 9, 2016
@bengl @addaleax
doc: add added: information for process
ec67abe 
Most of the information is gleaned from changelogs. The rest is inferred
from git history.

Omitted cpuUsage() since it's not yet in a release.

Also omitted the streams, events and signals, since I didn't really
think it made sense for those.

Ref: #6578
PR-URL: #6589
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Alexander Makarenko <estliberitas@gmail.com>
@addaleax
Copy link
Member

addaleax commented May 9, 2016

Landed in ec67abe.

@addaleax addaleax closed this May 9, 2016
evanlucas pushed a commit that referenced this pull request May 17, 2016
@bengl @evanlucas
doc: add added: information for process
58cd11c 
Most of the information is gleaned from changelogs. The rest is inferred
from git history.

Omitted cpuUsage() since it's not yet in a release.

Also omitted the streams, events and signals, since I didn't really
think it made sense for those.

Ref: #6578
PR-URL: #6589
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Alexander Makarenko <estliberitas@gmail.com>
@evanlucas evanlucas mentioned this pull request May 17, 2016
Merged
@addaleax addaleax mentioned this pull request May 18, 2016
Closed
2 tasks
@addaleax addaleax mentioned this pull request Jul 12, 2016
Closed
addaleax pushed a commit to addaleax/node that referenced this pull request Jul 12, 2016
@bengl @addaleax
doc: add added: information for process
60dbf2a 
Most of the information is gleaned from changelogs. The rest is inferred
from git history.

Omitted cpuUsage() since it's not yet in a release.

Also omitted the streams, events and signals, since I didn't really
think it made sense for those.

Ref: nodejs#6578
PR-URL: nodejs#6589
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Alexander Makarenko <estliberitas@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@bengl
doc: add added: information for process
1511f73 
Most of the information is gleaned from changelogs. The rest is inferred
from git history.

Omitted cpuUsage() since it's not yet in a release.

Also omitted the streams, events and signals, since I didn't really
think it made sense for those.

Ref: #6578
PR-URL: #6589
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Alexander Makarenko <estliberitas@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@bengl
doc: add added: information for process
8fdd3f7 
Most of the information is gleaned from changelogs. The rest is inferred
from git history.

Omitted cpuUsage() since it's not yet in a release.

Also omitted the streams, events and signals, since I didn't really
think it made sense for those.

Ref: #6578
PR-URL: #6589
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Alexander Makarenko <estliberitas@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 12, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@bengl
doc: add added: information for process
d0ec6e8 
Most of the information is gleaned from changelogs. The rest is inferred
from git history.

Omitted cpuUsage() since it's not yet in a release.

Also omitted the streams, events and signals, since I didn't really
think it made sense for those.

Ref: #6578
PR-URL: #6589
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Alexander Makarenko <estliberitas@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@bengl
doc: add added: information for process
fcb4e41 
Most of the information is gleaned from changelogs. The rest is inferred
from git history.

Omitted cpuUsage() since it's not yet in a release.

Also omitted the streams, events and signals, since I didn't really
think it made sense for those.

Ref: #6578
PR-URL: #6589
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Alexander Makarenko <estliberitas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bengl @jasnell @addaleax @Qard @estliberitas @MylesBorins @nodejs-github-bot