deps: backport IsValid changes from 4e8736d in V8 (v4.x) #6669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
V8 erroneously did null pointer checks on `this`. It can lead to a SIGSEGV crash if node is compiled with GCC 6. Backport relevant changes from [1] that fix this issue. [1]: https://codereview.chromium.org/1900423002 Fixes: nodejs#6272
| @@ -869,6 +869,8 @@ class FrameStateDescriptor : public ZoneObject { | |||
| MaybeHandle<SharedFunctionInfo> shared_info, | |||
| FrameStateDescriptor* outer_state = nullptr); | |||
|
|
|||
| static size_t GetTotalSize(FrameStateDescriptor* desc); | |||
There was a problem hiding this comment.
const FrameStateDescriptor*?
EDIT: Existing V8 code plays fast and loose with const correctness so I suppose it doesn't matter too much.
Sounds like a good idea. |
|
CI is green @bnoordhuis is there anything else for you to give an LGTM? |
|
|
||
| size_t FrameStateDescriptor::GetTotalSize() const { | ||
| size_t FrameStateDescriptor::GetTotalSize(const FrameStateDescriptor* desc) { | ||
| if (desc == NULL) return 0; |
There was a problem hiding this comment.
This nullptr check is not strictly necessary. Same for the corresponding checks in the other methods.
|
@bnoordhuis I addressed your comments, PTAL. |
|
LGTM |
1 similar comment
|
LGTM |
MylesBorins
pushed a commit
that referenced
this pull request
May 11, 2016
V8 erroneously did null pointer checks on `this`. It can lead to a SIGSEGV crash if node is compiled with GCC 6. Backport relevant changes from [1] that fix this issue. [1]: https://codereview.chromium.org/1900423002 Fixes: #6272 PR-URL: #6669 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 11, 2016
fix null pointer checks in V8's FrameStateDescriptor PR-URL: #6669 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
|
landed in 53d33a4...14013d8 |
MylesBorins
pushed a commit
that referenced
this pull request
May 18, 2016
V8 erroneously did null pointer checks on `this`. It can lead to a SIGSEGV crash if node is compiled with GCC 6. Backport relevant changes from [1] that fix this issue. [1]: https://codereview.chromium.org/1900423002 Fixes: #6272 PR-URL: #6669 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 18, 2016
fix null pointer checks in V8's FrameStateDescriptor PR-URL: #6669 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
gibfahn
pushed a commit
to ibmruntimes/node
that referenced
this pull request
May 25, 2016
V8 erroneously did null pointer checks on `this`. It can lead to a SIGSEGV crash if node is compiled with GCC 6. Backport relevant changes from [1] that fix this issue. [1]: https://codereview.chromium.org/1900423002 Fixes: nodejs/node#6272 PR-URL: nodejs/node#6669 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn
pushed a commit
to ibmruntimes/node
that referenced
this pull request
May 25, 2016
fix null pointer checks in V8's FrameStateDescriptor PR-URL: nodejs/node#6669 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
v8
Description of change
Cherry-pick changes from #6544 to
v4.x-staging.I added another commit to make a similar fix to
FrameStateDescriptor::GetTotalSize(some of our tests were crashing before it). The tests now pass but I could also changeGetFrameCountandGetJSFrameCountfor more safety ?R= @bnoordhuis
CC @nodejs/v8