New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add `added:` information for fs #6717

Closed

addaleax wants to merge 1 commit into nodejs:master from addaleax:fsychiology

Member

addaleax commented May 12, 2016

Checklist

documentation is changed or added
the commit message follows commit guidelines

Affected core subsystem(s)

doc

Description of change

Ref: #6578

addaleax added doc fs labels

sam-github mentioned this pull request

docs do not state at what version an API was introduced (or deprecated) #6578

Closed

36 tasks


          doc: add added: information for fs

9bcb2cc

Ref: nodejs#6578

addaleax force-pushed the fsychiology branch from 4b49e35 to 9bcb2cc Compare

May 12, 2016 19:04

Member Author

addaleax commented May 16, 2016

ping @nodejs/documentation … anybody minds reviewing this? ;)

Contributor

eljefedelrodeodeljefe commented May 16, 2016

LGTM. Didn't have a look at the rendering, but couldn't find anything that breaks. Who is doing all that research for history and how? By hand?

Member Author

addaleax commented May 16, 2016

@eljefedelrodeodeljefe For the “who”… see the issue linked above, so far that’s me, @bengl and @Trott, but you’re definitely invited to join the party. And the method depends, but git blame, git log and the changelog are massively helpful tools. So yeah, you could say “by hand”.

Contributor

eljefedelrodeodeljefe commented May 16, 2016

Yeah, I was thinking so. Then please have my shout-outs! When I see some I add some... good work!

Member

jasnell commented May 17, 2016

LGTM.
And big thanks to @addaleax, @bengl, and @Trott for all the hard work on this. It's very appreciated.

Member Author

addaleax commented May 17, 2016

Landed in ba10ea8

addaleax closed this

addaleax deleted the fsychiology branch

May 17, 2016 21:18

addaleax added a commit that referenced this pull request


          doc: add added: information for fs

ba10ea8

Ref: #6578
PR-URL: #6717
Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Fishrock123 pushed a commit that referenced this pull request


          doc: add added: information for fs

69fcbd8

Ref: #6578
PR-URL: #6717
Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added the dont-land-on-v4.x label

rvagg pushed a commit that referenced this pull request


          doc: add added: information for fs

5a1e823

Ref: #6578
PR-URL: #6717
Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

richardlau mentioned this pull request

doc: Correct added: information for fs.access and fs.accessSync #7299

Closed

2 tasks

addaleax pushed a commit that referenced this pull request


          doc: correct added: information for fs.access

a06ccdb

fs.access and fs.accessSync were added to Node v0.11.15 via 2944934

PR-URL: #7299
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Ref: #6717
Ref: #6578

evanlucas pushed a commit that referenced this pull request


          doc: correct added: information for fs.access

cd7c29e

fs.access and fs.accessSync were added to Node v0.11.15 via 2944934

PR-URL: #7299
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Ref: #6717
Ref: #6578

addaleax mentioned this pull request

Backport fs added: info #7679

Closed

addaleax added a commit to addaleax/node that referenced this pull request


          doc: add added: information for fs

3c398de

Ref: nodejs#6578
PR-URL: nodejs#6717
Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax pushed a commit to addaleax/node that referenced this pull request


          doc: correct added: information for fs.access

cb8fae6

fs.access and fs.accessSync were added to Node v0.11.15 via 2944934

PR-URL: nodejs#7299
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Ref: nodejs#6717
Ref: nodejs#6578

MylesBorins pushed a commit that referenced this pull request


          doc: add added: information for fs

d8f22f1

Ref: #6578
PR-URL: #6717
Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request


          doc: correct added: information for fs.access

38330ca

fs.access and fs.accessSync were added to Node v0.11.15 via 2944934

PR-URL: #7299
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Ref: #6717
Ref: #6578

MylesBorins pushed a commit that referenced this pull request


          doc: add added: information for fs

dd800bd

Ref: #6578
PR-URL: #6717
Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request


          doc: correct added: information for fs.access

03ff2f9

fs.access and fs.accessSync were added to Node v0.11.15 via 2944934

PR-URL: #7299
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Ref: #6717
Ref: #6578

MylesBorins mentioned this pull request

v4.5.0 proposal #7688

Merged

MylesBorins pushed a commit that referenced this pull request


          doc: add added: information for fs

9c0694c

Ref: #6578
PR-URL: #6717
Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request


          doc: correct added: information for fs.access

10e1bc8

fs.access and fs.accessSync were added to Node v0.11.15 via 2944934

PR-URL: #7299
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Ref: #6717
Ref: #6578

MylesBorins pushed a commit that referenced this pull request


          doc: add added: information for fs

1e9d27c

Ref: #6578
PR-URL: #6717
Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request


          doc: correct added: information for fs.access

fd4aa6c

fs.access and fs.accessSync were added to Node v0.11.15 via 2944934

PR-URL: #7299
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Ref: #6717
Ref: #6578

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc fs