Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4.4.5 proposal #6824

Merged
merged 76 commits into from
May 24, 2016
Merged

v4.4.5 proposal #6824

merged 76 commits into from
May 24, 2016

Commits on May 18, 2016

  1. src,tools: allow utf-8 in built-in js source code

    PR-URL: #5418
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    bnoordhuis authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    d7a3ea4 View commit details
    Browse the repository at this point in the history
  2. src,tools: drop nul byte from built-in source code

    PR-URL: #5418
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    bnoordhuis authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    8f18414 View commit details
    Browse the repository at this point in the history
  3. src,tools: remove null sentinel from source array

    PR-URL: #5418
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    bnoordhuis authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    e0eebf4 View commit details
    Browse the repository at this point in the history
  4. deps: upgrade npm in LTS to 2.15.2

    zkat authored and Myles Borins committed May 18, 2016
    1 Configuration menu
    Copy the full SHA
    df29901 View commit details
    Browse the repository at this point in the history
  5. tools: remove obsolete npm test-legacy command

    zkat authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    4e6ea7f View commit details
    Browse the repository at this point in the history
  6. http: Corrects IPv6 address in Host header

    IPv6 addresses in Host header (URI), must be enclosed within
    square brackets, in order to properly separate the host address
    from any port reference.
    
    PR-URL: #5314
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    mpotra authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    b28e44d View commit details
    Browse the repository at this point in the history
  7. stream: Fix readableState.awaitDrain mechanism

    In 6899094 (#2325),
    the conditions for increasing `readableState.awaitDrain` when
    writing to a piping destination returns false were changed so
    that they could not actually be met, effectively leaving
    `readableState.awaitDrain` with a constant value of 0.
    
    This patch changes the conditions to testing whether the
    stream for which `.write()` returned false is still a piping
    destination, which was likely the intention of the original
    patch.
    
    Fixes: #5820
    Fixes: #5257
    PR-URL: #6023
    Reviewed-By: Brian White <mscdex@mscdex.net>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    addaleax authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    51c0808 View commit details
    Browse the repository at this point in the history
  8. assert: respect assert.doesNotThrow message.

    Special handling to detect when user has supplied a custom message.
    Added a test for user message.
    When testing if `actual` value is an error use
    `util.isError` instead of `instanceof`.
    
    Fixes: #2385
    PR-URL: #2407
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Ilya Shaisultanov authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    59a977d View commit details
    Browse the repository at this point in the history
  9. tools,doc: parse types in braces everywhere

    Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`,
    `TypeError`, `URIError` to list of global types. Fix errors.markdown
    copy accordingly.
    
    Fixes: #5325.
    PR-URL: #5329
    Reviewed-By: James M Snell <jasnell@gmail.com>
    estliberitas authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    c893cd3 View commit details
    Browse the repository at this point in the history
  10. build: add suport for x86 architecture

    Modified android-configure script to support also x86 arch.
    Currently added support only for ia32 target arch.
    Also, compile openssl without asm, since using the asm sources will make
    node fail to run on Android, because it adds text relocations.
    
    Signed-off-by: Robert Chiras <robert.chiras@intel.com>
    PR-URL: #5544
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    robertchiras authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    4ad7184 View commit details
    Browse the repository at this point in the history
  11. build: add script to create Android .mk files

    The create_android_makefiles script will create .mk files for node and
    all of its dependencies ready to be build using Android build system.
    
    Signed-off-by: Robert Chiras <robert.chiras@intel.com>
    PR-URL: #5544
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    robertchiras authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    918d33a View commit details
    Browse the repository at this point in the history
  12. test: refactor http-end-throw-socket-handling

    Remove timer to avoid the test timing out occasionally.
    
    PR-URL: #5676
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
    santigimeno authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    3d4d577 View commit details
    Browse the repository at this point in the history
  13. tools,doc: fix json for grouped optional params

    Current tools/doc/json.js only supports one bracket style for optional
    params methodName(param0[,param1],param2). Add support to other styles
    such as methodName(param0,[param1,]param2) or
    methodName(param0[,param1,param2]) or
    methodName(param0[,param1[,param2]]).
    
    PR-URL: #5977
    Fixes: #5976
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Robert Lindstädt <robert.lindstaedt@gmail.com>
    Reviewed-By: Roman Reiss <me@silverwind.io>
    firedfox authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    4c73ab4 View commit details
    Browse the repository at this point in the history
  14. build: fix make tar-headers for Linux

    The tar-headers target tries to find and delete links in the
    tar folder, which fails as no links are found. Use rm -f to
    avoid this.
    
    Remove the config.gypi dependency, as the target runs configure
    itself.
    
    PR-URL: #5978
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    gibfahn authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    292b1b7 View commit details
    Browse the repository at this point in the history
  15. doc: fix http response event, Agent#getName

    Removes the options block from the http 'response' event and attaches
    it to Agent#getName where it belongs. Removes socketPath and documents
    localAddress option.
    
    PR-URL: #5993
    Reviewed-By: James M Snell <jasnell@gmail.com>
    mdouglass authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    6a197ec View commit details
    Browse the repository at this point in the history
  16. tools: remove disabling of already-disabled rule

    `require-buffer` is only enabled in the `lib` directory. There is no
    need to disable it in `test`.
    
    PR-URL: #6013
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Trott authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    4fb4ba9 View commit details
    Browse the repository at this point in the history
  17. doc: minor argument formatting in stream.markdown

    Fixes: #4350
    PR-URL: #6016
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    jasnell authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    6d56009 View commit details
    Browse the repository at this point in the history
  18. src: add missing 'inline' keywords

    The BaseObject constructor and destructor should not have external
    linkage because BaseObject is a header-only construct.  Add the
    necessary 'inline' keywords.
    
    PR-URL: #6056
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    bnoordhuis authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    2942cff View commit details
    Browse the repository at this point in the history
  19. doc: clarifies http.serverResponse implementation

    Since http.serverResponse does not inherit from Stream.writable
    it does not pass the test `serverResponse instanceof stream.Writable`.
    This commit clarifies that serverResponse does not inherit from
    stream.Writable and therefore should not be expected to pass the above
    test
    
    Fixes: #6046
    PR-URL: #6072
    Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
    Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com>
    Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    AllenSH12 authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    29f821b View commit details
    Browse the repository at this point in the history
  20. deps: backport 125ac66 from v8 upstream

    As requested in #5221
    
    Original commit message:
    
      fix debug command processor wrt restart frame.
    
      R=jkummerow@chromium.org
      BUG=v8:4757
      LOG=N
    
      Review URL: https://codereview.chromium.org/1700693002
    
      Cr-Commit-Position: refs/heads/master@{#33983}
    
    PR-URL: #6086
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    d1fca27 View commit details
    Browse the repository at this point in the history
  21. doc: clarify fs.watch() and inodes on linux, os x

    On Linux and OS X systems, `fs.watch()` resolves the watched path to an
    inode. This clarifies that `fs.watch()` watches the inode and not the
    path. If the inode of the path subsequently changes, `fs.watch()` will
    continue watching the original inode and events for the path will no
    longer be emitted. This is expected behavior.
    
    Fixes: #5039
    PR-URL: #6099
    Reviewed-By: James M Snell <jasnell@gmail.com>
    jorangreef authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    30f354f View commit details
    Browse the repository at this point in the history
  22. doc: native module reloading is not supported

    Clarify in docs for require.cache that reloading native modules
    isn't supported.
    
    Related: #6160
    PR-URL: #6168
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Brian White <mscdex@mscdex.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    bengl authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    df5ce6f View commit details
    Browse the repository at this point in the history
  23. doc: explain differences in console.assert between node and browsers

    Provide an example for implementing browser like behavior for console.assert.
    
    This "fixes" #5340 by providing an
    alternative to changing Node.js' implemented behavior. Instead, we
    document the differences and show how to work around them if
    browser like semantics are desired.
    
    Fixes: #5340
    PR-URL: #6169
    Reviewed-By: Robert Jefe Lindstädt <robert.lindstaedt@gmail.com>
    Reviewed-By: Jeff Harris <@techjeffharris>
    jasnell authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    4ec9ae8 View commit details
    Browse the repository at this point in the history
  24. deps: cherry-pick 1383d00 from v8 upstream

    Original commit message:
    
        tools: fix tickprocessor Cpp symbols on mac
    
        Despite man page documentation:
    
            -f Display the symbol table of a dynamic library flat (as one
               file not separate modules).
    
        `nm` on mac treats `-f` as a shorthand for `-format`. The `-f` argument
        does not seem to be required, so just remove it completely.
    
        (For `-format` documentation - see `nm --help` on mac).
    
        BUG=
    
        Review URL: https://codereview.chromium.org/1840633002
    
        Cr-Commit-Position: refs/heads/master@{#35445}
    
    Fix: #5903
    PR-URL: #6179
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
    indutny authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    433fb9a View commit details
    Browse the repository at this point in the history
  25. doc: revert backported commits

    This reverts changes found in daf3ef6 0943001 that incorrectly
    updated the docs for `path.format`
    
    PR-URL: #6530
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    3695690 View commit details
    Browse the repository at this point in the history
  26. doc: get rid of sneaky hard tabs in CHANGELOG

    My editor did something strange. Sorry about that
    
    PR-URL: #6608
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    fcc6a34 View commit details
    Browse the repository at this point in the history
  27. doc: add steps for running addons + npm tests

    Currently we do not document how to run the test suite for native
    modules or for npm. This commit updates BUILDING.md with the
    information needed to do so. It includes a caveat about Node v4
    and earlier requiring `make install` to be run before running the npm
    test suite.
    
    PR-URL: #6231
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    29e25d8 View commit details
    Browse the repository at this point in the history
  28. deps: upgrade npm in LTS to 2.15.4

    PR-URL: #6663
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    iarna authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    855604c View commit details
    Browse the repository at this point in the history
  29. deps: backport IsValid changes from 4e8736d in V8

    V8 erroneously did null pointer checks on `this`.
    It can lead to a SIGSEGV crash if node is compiled with GCC 6.
    Backport relevant changes from [1] that fix this issue.
    
    [1]: https://codereview.chromium.org/1900423002
    
    Fixes: #6272
    
    PR-URL: #6669
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    targos authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    a40730b View commit details
    Browse the repository at this point in the history
  30. deps: fix null pointer checks in v8

    fix null pointer checks in V8's FrameStateDescriptor
    
    PR-URL: #6669
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    targos authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    3c50350 View commit details
    Browse the repository at this point in the history
  31. test: ensure test-npm-install uses correct node

    Currently it is possible that the shelled out instance of npm will use
    the system copy of node. This PR changes the test to shim the build
    directory into the path. This will ensure that npm will use the correct
    version of node.
    
    fixes: #6648
    
    PR-URL: #6658
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    cc4c518 View commit details
    Browse the repository at this point in the history
  32. test: fix flakiness of stringbytes-external

    The tests used to rely on precise timing of when a JavaScript object
    would be garbage collected to ensure that there is enough memory
    available on the system. Switch the test to use a malloc/free pair
    instead.
    
    Ref: #5945
    Ref: #6039
    Ref: #6073
    
    PR-URL: #6705
    Reviewed-By: James M Snell <jasnell@gmail.com>
    ofrobots authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    7b60b8f View commit details
    Browse the repository at this point in the history
  33. buffer: fix needle length misestimation for UCS2

    Use `StringBytes::Size` to determine the needle string length
    instead of assuming latin-1 or UTF-8.
    
    Previously, `Buffer.indexOf` could fail with an assertion failure
    when the needle's byte length, but not its character count,
    exceeded the haystack's byte length.
    
    PR-URL: #6511
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    addaleax authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    12a9699 View commit details
    Browse the repository at this point in the history
  34. buffer: fix UCS2 indexOf for odd buffer length

    Fix `buffer.indexOf` for the case that the haystack has odd length
    and the needle is not found in it. `StringSearch()` would return
    the length of the buffer in multiples of `sizeof(uint16_t)`, but
    checking that against `haystack_length` would not work if the latter
    one was odd.
    
    PR-URL: #6511
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    addaleax authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    8b077fa View commit details
    Browse the repository at this point in the history
  35. src: fix FindFirstCharacter argument alignment

    PR-URL: #6511
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    addaleax authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    2fac15b View commit details
    Browse the repository at this point in the history
  36. doc: fix issues related to page scrolling

    Moved the sidebar to a fixed position and moved the main column to the
    page's body, which results in back/forward navigation through hash
    links and search highlight working again.
    
    Fixes: #6637
    Fixes: #6751
    Based on: #5716
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com>
    silverwind authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    126fdc3 View commit details
    Browse the repository at this point in the history
  37. deps: upgrade npm in LTS to 2.15.5

    iarna authored and Myles Borins committed May 18, 2016
    1 Configuration menu
    Copy the full SHA
    0dc875e View commit details
    Browse the repository at this point in the history
  38. http: unref socket timer on parser execute

    When underlying `net.Socket` instance is consumed in http server - no
    `data` events are emitted, and thus `socket.setTimeout` fires the
    callback even if the data is constantly flowing into the socket.
    
    Fix this by calling `socket._unrefTimer()` on every `onParserExecute`
    call.
    
    Fix: #5899
    PR-URL: #6286
    Reviewed-By: James M Snell <jasnell@gmail.com>
    indutny authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    9a8b531 View commit details
    Browse the repository at this point in the history
  39. doc: update openssl.org hash links

    The hash link format has changed from #HASH_LINK to #HASH-LINK.
    
    PR-URL: #6817
    Reviewed-By: Roman Klauke <romankl@users.noreply.github.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    silverwind authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    840c094 View commit details
    Browse the repository at this point in the history
  40. test: fix pummel test failures

    A handful of tests in `test/pummel` were failing due to undefined
    variables.
    
    The tests in pummel are not run in CI or otherwise exercised regularly
    so these failures can go unnoticed for a long time.
    
    PR-URL: #6012
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Trott authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    0b376cb View commit details
    Browse the repository at this point in the history
  41. test: enforce strict mode for test-domain-crypto

    The last change to this test landed before a nit about strict mode was
    addressed, so this change addresses that.
    
    PR-URL: #6047
    Refs: #6017
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
    Trott authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    3a67a05 View commit details
    Browse the repository at this point in the history
  42. test: refactor test-file-write-stream3

    * use common.mustCall() to verify all tests have run
    * eliminate unneeded removeTestFile()
    * eliminate unneeded var leaking into global scope
    * var -> const
    * remove instance of let
    
    PR-URL: #6050
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    28040cc View commit details
    Browse the repository at this point in the history
  43. doc: describe child.kill() pitfalls on linux

    This commit refines the documentation around child.kill(), where kill
    attempts against shells will lead to unexpected results. Namely, on
    linux the child process of a child process will not terminate, when
    its parent gets terminated. This is different across the the
    platforms.
    
    PR-URL: #2098
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Closes: #2098
    eljefedelrodeodeljefe authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    59814ac View commit details
    Browse the repository at this point in the history
  44. test: move some test from sequential to parallel

    The only test with modifications is `test-stdin-child-proc` that was
    passing when it should not because the exit code of the child process
    was not being checked.
    
    PR-URL: #6087
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
    santigimeno authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    25d4b5b View commit details
    Browse the repository at this point in the history
  45. tools: remove simplejson dependency

    As Node.js expects either Python 2.6 or 2.7 installed to work properly,
    simplejson module is no longer necessary. It was included in Python 2.6
    as the json module.
    
    PR-URL: #6101
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
    thefourtheye authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    68c7de4 View commit details
    Browse the repository at this point in the history
  46. test: fix flaky test-http-client-abort

    Fixes: #6080
    PR-URL: #6124
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Brian White <mscdex@mscdex.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    a865975 View commit details
    Browse the repository at this point in the history
  47. tools: update ESLint to 2.7.0

    PR-URL: #6132
    Reviewed-By: Brian White <mscdex@mscdex.net>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: thefourtheye <thechargingvolcano@gmail.com>
    silverwind authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    1aa6c5b View commit details
    Browse the repository at this point in the history
  48. test: fix issues for ESLint 2.7.0

    PR-URL: #6132
    Reviewed-By: Brian White <mscdex@mscdex.net>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: thefourtheye <thechargingvolcano@gmail.com>
    silverwind authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    a97a6a9 View commit details
    Browse the repository at this point in the history
  49. test: fix flaky test-child-process-fork-net

    Reduce client connections from 10 to 4 in a test that is causing issues
    on Raspberry Pi 2 devices in CI.
    
    Fixes: #5122
    PR-URL: #6138
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Trott authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    69dcbb6 View commit details
    Browse the repository at this point in the history
  50. test: fix test-net-settimeout flakiness

    Wait for the data to be received by the socket before creating the
    clean-up timer. This way, a possible (though unlikely) `ECONNRESET`
    error can be avoided.
    
    PR-URL: #6166
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    santigimeno authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    37cc249 View commit details
    Browse the repository at this point in the history
  51. doc: add full example for zlib.flush()

    Add a full example using `zlib.flush()` for the common use
    case of writing partial compressed HTTP output to the client.
    
    PR-URL: #6172
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Robert Jefe Lindstädt <robert.lindstaedt@gmail.com>
    addaleax authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    d069f2d View commit details
    Browse the repository at this point in the history
  52. doc: note that zlib.flush acts after pending writes

    Describe that `zlib.flush()` may wait for pending writes and
    until output is being read from the stream.
    
    Fixes: #3782
    PR-URL: #6172
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Robert Jefe Lindstädt <robert.lindstaedt@gmail.com>
    addaleax authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    7160229 View commit details
    Browse the repository at this point in the history
  53. test: move more tests from sequential to parallel

    Only `test-stdin-from-file.js` has been modified so that the `stdin.txt`
    is written in a temp directory instead of the `fixtures` directory.
    
    PR-URL: #6187
    Reviewed-By: James M Snell <jasnell@gmail.com>
    santigimeno authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    0f9405d View commit details
    Browse the repository at this point in the history
  54. doc: replace functions with arrow functions

    PR-URL: #6203
    Reviewed-By: James M Snell <jasnell@gmail.com>
    hiroppy authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    b872fea View commit details
    Browse the repository at this point in the history
  55. test,vm: enable strict mode for vm tests

    Some vm tests are not in strict mode because they need to create and use
    global variables. By using `global.foo` instead of just `foo`, we can
    still enable strict mode.
    
    PR-URL: #6209
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
    Trott authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    9222689 View commit details
    Browse the repository at this point in the history
  56. test: assert - fixed error messages to match the tests

    PR-URL: #6241
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    suryagh authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    5002a71 View commit details
    Browse the repository at this point in the history
  57. test: fix flaky test-http-set-timeout-server

    Make the servers listen on a free port number picked by the OS to avoid
    rare `EADDRINUSE` errors on `SmartOS`.
    
    Fixes: #6197
    PR-URL: #6248
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    santigimeno authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    24ac16f View commit details
    Browse the repository at this point in the history
  58. test,tools: enable linting for undefined vars

    The test directory had linting for undefined variables disabled. It is
    enabled everywhere else in the code base. Let's disable the fule for
    individual lines in the handful of tests that use undefined variables.
    
    PR-URL: #6255
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Roman Reiss <me@silverwind.io>
    Trott authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    c76f214 View commit details
    Browse the repository at this point in the history
  59. child_process: add nullptr checks after allocs

    Add `CHECK_NE(·, nullptr)` after allocations made when
    spawning child processes.
    
    PR-URL: #6256
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    addaleax authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    6ad8591 View commit details
    Browse the repository at this point in the history
  60. tools: lint rule for assert.fail()

    `assert.fail()` is often mistakenly used with a single argument even in
    Node.js core. (See fixes to previous instances in
    b7f4b1b,
    28e9a02. and
    676e618.)
    
    This commit adds a linting rule to identify instances of this issue.
    
    PR-URL: #6261
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Trott authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    8fa2029 View commit details
    Browse the repository at this point in the history
  61. tools: enable linting for v8_prof_processor.js

    `lib/internal/v8_prof_processor.js` was being excluded from linting, but
    the only lint issue it has is that it cannot run in strict mode. Disable
    the `strict` rule with a comment and remove the file from
    `.eslintignore`.
    
    PR-URL: #6262
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    b8c9d6b View commit details
    Browse the repository at this point in the history
  62. zlib: fix use after null when calling .close

    An internal zlib error may cause _handle to be set to null.
    Close now will check if there is a _handle prior to calling .close on
    it.
    
    PR-URL: #5982
    Fixes: #6034
    Reviewed-By: Brian White <mscdex@mscdex.net>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    lightsofapollo authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    48684af View commit details
    Browse the repository at this point in the history
  63. test: add zlib close-after-error regression test

    Add a regression test based on the report in
    #6034.
    
    PR-URL: #6270
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    addaleax authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    f60ba54 View commit details
    Browse the repository at this point in the history
  64. http: disallow sending obviously invalid status codes

    PR-URL: #6291
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
    Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    mscdex authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    620a261 View commit details
    Browse the repository at this point in the history
  65. test: add tests for console.assert

    There were previously no tests where console.assert failed
    
    PR-URL: #6302
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Brian White <mscdex@mscdex.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    evanlucas authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    06e5faf View commit details
    Browse the repository at this point in the history
  66. test: increase the platform timeout for AIX

    There have been failures on AIX due to the slower
    default loopback performance. So far I've resisted
    updating the global timeout but seeing another
    new failure in a newly added test I now think the
    right thing is to just extend the platform
    timeout for AIX. This commit does that.
    
    PR-URL: #6342
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    mhdawson authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    333369e View commit details
    Browse the repository at this point in the history
  67. test: include component in tap output

    Print test name as (for example) "parallel/test-assert".  Tests that are
    scraped from the addons documentation are all named test.js, making it
    hard to decipher what test is running when only the filename is printed.
    
    Fixes: #6651
    PR-URL: #6653
    Reviewed-By: James M Snell <jasnell@gmail.com>
    bnoordhuis authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    773ea20 View commit details
    Browse the repository at this point in the history
  68. doc: update vm.runInDebugContext() example

    The debugger needs to be active now before one is allowed to query the
    list of scripts.  Replace the example with one that works without
    installing a debug event listener first.
    
    Fixes: #4862
    PR-URL: #6757
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    bnoordhuis authored and Myles Borins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    50f02bd View commit details
    Browse the repository at this point in the history

Commits on May 20, 2016

  1. contextify: cleanup weak ref for global proxy

    Cleanup how node_contextify keeps weak references in order to prepare
    for new style phantom weakness API. We didn't need to keep a weak
    reference to the context's global proxy, as the context holds it.
    
    PR-URL: #5392
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    ofrobots authored and Myles Borins committed May 20, 2016
    Configuration menu
    Copy the full SHA
    b6fc153 View commit details
    Browse the repository at this point in the history
  2. contextify: cleanup weak ref for sandbox

    Simplify how node_contextify was keeping a weak reference to the
    sandbox object in order to prepare for new style phantom weakness V8
    API. It is simpler (and more robust) for the context to hold a
    reference to the sandbox in an embedder data field. Doing otherwise
    meant that the sandbox could become weak while the context was still
    alive. This wasn't a problem because we would make the reference
    strong at that point.
    
    Since the sandbox must live at least as long as the context, it
    would be better for the context to hold onto the sandbox.
    
    PR-URL: #5392
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    ofrobots authored and Myles Borins committed May 20, 2016
    Configuration menu
    Copy the full SHA
    9e6d817 View commit details
    Browse the repository at this point in the history
  3. contextify: replace deprecated SetWeak usage

    PR-URL: #5392
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    ofrobots authored and Myles Borins committed May 20, 2016
    Configuration menu
    Copy the full SHA
    8ebdcd6 View commit details
    Browse the repository at this point in the history
  4. contextify: cache sandbox and context in locals

    PR-URL: #5392
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    ofrobots authored and Myles Borins committed May 20, 2016
    Configuration menu
    Copy the full SHA
    9ddb44b View commit details
    Browse the repository at this point in the history
  5. contextify: tie lifetimes of context & sandbox

    When the previous set of changes (bfff07b) it was possible to have the
    context get garbage collected while sandbox was still live. We need to
    tie the lifetime of the context to the lifetime of the sandbox.
    
    This is a backport of #5786 to v5.x.
    
    Ref: #5786
    PR-URL: #5800
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    ofrobots authored and Myles Borins committed May 20, 2016
    Configuration menu
    Copy the full SHA
    823f726 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2016

  1. test: add logging for test-debug-port-cluster

    The test is currently flaky and CI provides no real information because
    the test times out rather than failing on an assertion. Add logging to
    gather more information about the failure.
    
    Refs: #6754
    PR-URL: #6769
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Trott authored and Myles Borins committed May 23, 2016
    Configuration menu
    Copy the full SHA
    f8144e4 View commit details
    Browse the repository at this point in the history
  2. test: fix test-debug-port-cluster flakiness

    Remove port increment by `1337` which appears to sometimes result in a
    port that is already in use. There is no reason not to use
    `common.PORT`.
    
    PR-URL: #6769
    Fixes: #6754
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Trott authored and Myles Borins committed May 23, 2016
    Configuration menu
    Copy the full SHA
    49a5941 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2016

  1. 2016-05-24, Version 4.4.5 'Argon' (LTS)

    Notable changes:
    
    * **buffer**:
      * Buffer no longer errors if you call lastIndexOf with a search term
        longer than the buffer (Anna Henningsen)
        #6511
    
    * contextify:
      * Context objects are now properly garbage collected, this solves a
        problem some individuals were experiencing with extreme memory
        growth (Ali Ijaz Sheikh)
        #6871
    
    * deps:
      * update npm to 2.15.5 (Rebecca Turner)
        #6663
    
    * http:
      * Invalid status codes can no longer be sent. Limited to 3 digit
        numbers between 100 - 999 (Brian White)
        #6291
    Myles Borins committed May 24, 2016
    Configuration menu
    Copy the full SHA
    6330f48 View commit details
    Browse the repository at this point in the history