src: add include guards to internal headers

[bnoordhuis]

For consistency with the newly added src/base64.h header, check that
NODE_WANT_INTERNALS is defined and set in internal headers.

Refs: #6910
CI: https://ci.nodejs.org/job/node-test-pull-request/2758/

R=@indutny @trevnorris

[trevnorris]

LGTM. Should this be documented in our addons docs?

[bnoordhuis]

What in particular does 'this' refer to?

[trevnorris]

@bnoordhuis In all of test/addons there's an added 'NODE_WANT_INTERNALS=1' and was wondering if that gyp option should be documented somewhere.

[bnoordhuis]

I only added it to the binding.gyp files from add-ons that #include "util.h" (because they use CHECK.)

As to documenting NODE_WANT_INTERNALS, it's expressly not the intent that third-party add-ons can include internal files. =)

[trevnorris]

Heh, fair enough.

[Fishrock123]

Isn't this kind of breaking?

[bnoordhuis]

Only on smartos, apparently.

Jest aside, all of these files are internal - people are not supposed to be using them and if they do, they should expect things to break at any time. The installer doesn't install them.

New CI: https://ci.nodejs.org/job/node-test-pull-request/2764/

[trevnorris]

The installer doesn't install them.

Can you tell me why this compiles fine (tested on v4 and v6)?

#include <v8.h>
#include <async-wrap.h>
#include <node.h>

namespace bmod {

using v8::FunctionCallbackInfo;
using v8::Value;
using v8::Local;
using v8::Object;

void Run(const FunctionCallbackInfo<Value>& args) {
  fprintf(stderr, "NODE_ASYNC_ID_OFFSET: %i\n", NODE_ASYNC_ID_OFFSET);
}

void Init(Local<Object> exports) {
  NODE_SET_METHOD(exports, "run", Run);
}

}  // namespace bmod
NODE_MODULE(addon, bmod::Init)

[bnoordhuis]

When I say installer, I mean tools/install.py. I don't know what the OS X or Windows installers do but the binary tarballs don't include internal headers.

If you use node-gyp though, that downloads and builds against the source tarball, and that does include internal headers.

[jasnell]

LGTM if CI is green

[indutny]

LGTM

[MylesBorins]

@bnoordhuis lts?

[bnoordhuis]

Let's not.