Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.gitigore: ignore AppCode's .idea folder #6963

Closed
wants to merge 1 commit into from
Closed

.gitigore: ignore AppCode's .idea folder #6963

wants to merge 1 commit into from

Conversation

chzhuo
Copy link

@chzhuo chzhuo commented May 25, 2016

Checklist
  • tests and code linting passes
  • a test and/or benchmark is included
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label May 25, 2016
@Fishrock123
Copy link
Contributor

We may accept this due to past history, but you should still add this to you global gitignore so that it doesn't conflict with other projects. Instructions at https://help.github.com/articles/ignoring-files/#create-a-global-gitignore

@Fishrock123 Fishrock123 added tools Issues and PRs related to the tools directory. meta Issues and PRs related to the general management of the project. and removed meta Issues and PRs related to the general management of the project. labels May 25, 2016
@jasnell
Copy link
Member

jasnell commented May 25, 2016

+0 on this. No objections in general but also not convinced it's necessary

@sam-github
Copy link
Contributor

I'm -1, I think we should encourage contributors to set up git correctly on their system, and that setting git up to ignore your personal editor's files is correct.

@gibfahn
Copy link
Member

gibfahn commented Oct 19, 2016

-1 for the same reasons, there are a bunch of different .directories we'd need to ignore to cover everything (one for every IDE that does this at least), and all the other things like .tags for ctags. If you're using these IDEs you almost certainly want them ignored in your other git projects as well, so a global .gitignore is probably a better way to go.

That said, maybe what would be more helpful is some documentation explaining that you can add a global .gitignore, maybe something in CONTRIBUTING.md?

@addaleax
Copy link
Member

I think this can be closed now that 15cc7c0 converted our .gitignore to a whitelist for dotfiles instead of a blacklist. Thanks for the PR, though!

@addaleax addaleax closed this Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants