Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add added: information for console #6995

Closed
wants to merge 1 commit into from

Conversation

edsadr
Copy link
Member

@edsadr edsadr commented May 26, 2016

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc, console

Description of change

doc: add added: information for console
Information extracted from git history.

Ref: #6578

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 26, 2016
@addaleax addaleax added the console Issues and PRs related to the console subsystem. label May 26, 2016
Information extracted from git history.

Ref: nodejs#6578
@edsadr edsadr force-pushed the add-added-console branch from c609946 to cf08831 Compare May 26, 2016 16:02
@addaleax
Copy link
Member

LGTM

@julianduque
Copy link
Contributor

LGTM

1 similar comment
@jasnell
Copy link
Member

jasnell commented May 27, 2016

LGTM

@julianduque
Copy link
Contributor

Landed in 611eef7, thanks @edsadr

addaleax pushed a commit to addaleax/node that referenced this pull request May 28, 2016
Information extracted from git history.

Ref: nodejs#6578
PR-URL: nodejs#6995
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Julian Duque <julianduquej@gmail.com>
@addaleax addaleax mentioned this pull request May 28, 2016
2 tasks
@addaleax
Copy link
Member

Re-landed in 51b8a79 with fixed metdata… @julianduque would be kinda cool if the Ref: field could contain the full issue URL, like the other commits here to… if nothing else, it makes it easier to open the issue from the git log :)

@julianduque
Copy link
Contributor

@addaleax noted! thank you. I did it for PR-URL but forgot Ref, will take it into account for the next time

Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request May 30, 2016
Information extracted from git history.

Ref: nodejs#6578
PR-URL: nodejs#6995
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Julian Duque <julianduquej@gmail.com>
rvagg pushed a commit that referenced this pull request Jun 2, 2016
Information extracted from git history.

Ref: #6578
PR-URL: #6995
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Julian Duque <julianduquej@gmail.com>
addaleax pushed a commit to addaleax/node that referenced this pull request Jul 12, 2016
Information extracted from git history.

Ref: nodejs#6578
PR-URL: nodejs#6995
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Julian Duque <julianduquej@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
Information extracted from git history.

Ref: #6578
PR-URL: #6995
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Julian Duque <julianduquej@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
Information extracted from git history.

Ref: #6578
PR-URL: #6995
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Julian Duque <julianduquej@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 12, 2016
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
Information extracted from git history.

Ref: #6578
PR-URL: #6995
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Julian Duque <julianduquej@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
Information extracted from git history.

Ref: #6578
PR-URL: #6995
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Julian Duque <julianduquej@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
console Issues and PRs related to the console subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants