doc: addresses nits in string_decoder, url, util #7026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| @@ -386,8 +386,7 @@ util.isError({ name: 'Error', message: 'an error occurred' }) | |||
| ``` | |||
|
|
|||
| Note that this method relies on `Object.prototype.toString()` behavior. It is | |||
| possible to obtain an incorrect result when the `object` argument manipulates | |||
| the `@@toStringTag` or overrides the `toString()` method. | |||
| possible to obtain an incorrect result when the `object` argument manipulates `@@toStringTag`. | |||
|
LGTM with a nit |
|
LGTM |
mscdex
added
util
|
LGTM |
- Only `@@toStringTag` affects `util.isError()`, this is the reason why it uses `Object.prototype.toString.call(argument)` under the hood. - Shows an actual Euro symbol for reference. - Uses line-drawing characters for the URL chart & fixes the chart borders. PR-URL: nodejs#7026 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Fishrock123
added a commit
that referenced
this pull request
Jun 1, 2016
- Only `@@toStringTag` affects `util.isError()`, this is the reason why it uses `Object.prototype.toString.call(argument)` under the hood. - Shows an actual Euro symbol for reference. - Uses line-drawing characters for the URL chart & fixes the chart borders. PR-URL: #7026 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
rvagg
pushed a commit
that referenced
this pull request
Jun 2, 2016
- Only `@@toStringTag` affects `util.isError()`, this is the reason why it uses `Object.prototype.toString.call(argument)` under the hood. - Shows an actual Euro symbol for reference. - Uses line-drawing characters for the URL chart & fixes the chart borders. PR-URL: #7026 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
@@toStringTagaffectsutil.isError(), this is the reason why weuse
Object.prototype.toString.call(argument)chart borders
Here's an example of the old and new chart: https://gist.github.com/Fishrock123/72cbf0b687573e1fc1f54622f05f6354
As a note, not all fonts may have proper font widths for all characters, so it is possible it may not show up perfectly in your editor depending on the font used. (I use a customized font in my editor.)
cc @jasnell & @nodejs/documentation