doc: general improvements to process.md copy #7029
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
added
doc
| is emitted with the following arguments: | ||
| The `'rejectionHandled'` event is emitted whenever a `Promise` has been rejected | ||
| and an error handler was attached to it (using [`promise.catch()`][], for | ||
| example) later than one turn of the Node.js event loop. |
There was a problem hiding this comment.
"later than one turn of the event loop" isn't correct - but I'm not sure we want to get into the real specifics, probably better to lie here.
There was a problem hiding this comment.
I will fix this at a later PR, don't hold it on this the current text isn't great either and is probably my fault :]
|
@nodejs/documentation ... PTAL |
|
ping @nodejs/documentation |
|
LGTM with a few nits about content and not formatting that can (and should) be addressed later. (I actually read it before and commented and forgot to leave the LGTM) |
jasnell
added a commit
that referenced
this pull request
Jun 6, 2016
PR-URL: #7029 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
|
Thank you! Landed in a32f7eb |
evanlucas
pushed a commit
that referenced
this pull request
Jun 15, 2016
PR-URL: #7029 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc (process)
Description of change
General improvements to process.md copy
@nodejs/documentation