Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: edit pull request template #7058

Closed
wants to merge 1 commit into from
Closed

doc: edit pull request template #7058

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
<!--
Thank you for your pull request. Please review below requirements and walk
through the checklist. You can 'tick' a box by using the letter "x": [x].
Thank you for your pull request. Please review below requirements.
Run the test suite with: `make -j4 test` on UNIX or `vcbuild test nosign` on
Windows.
Run tests with `make -j4 test` on UNIX or `vcbuild test nosign` on Windows.
If this aims to fix a regression or you’re adding a feature, make sure you also
write a test. If possible, include a benchmark that quantifies your changes.
Expand All @@ -13,7 +11,7 @@ https://github.com/nodejs/node/blob/master/CONTRIBUTING.md
-->

##### Checklist
<!-- remove lines that do not apply to you -->
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

- [ ] tests and code linting passes
- [ ] a test and/or benchmark is included
Expand Down