Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove disabled eio race test #7083

Closed
wants to merge 1 commit into from
Closed

test: remove disabled eio race test #7083

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented May 31, 2016

Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

The project does not use libeio anymore. Remove disabled libeio-specific
test.

R=@bnoordhuis

The project does not use libeio anymore. Remove disabled libeio-specific
test.
@Trott Trott added the test Issues and PRs related to the tests. label May 31, 2016
@cjihrig
Copy link
Contributor

cjihrig commented May 31, 2016

LGTM

2 similar comments
@mscdex
Copy link
Contributor

mscdex commented May 31, 2016

LGTM

@bnoordhuis
Copy link
Member

LGTM

@Trott
Copy link
Member Author

Trott commented Jun 3, 2016

Trott added a commit to Trott/io.js that referenced this pull request Jun 3, 2016
The project does not use libeio anymore. Remove disabled libeio-specific
test.

PR-URL: nodejs#7083
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@Trott
Copy link
Member Author

Trott commented Jun 3, 2016

Landed in 85fcc9f

@Trott Trott closed this Jun 3, 2016
evanlucas pushed a commit that referenced this pull request Jun 15, 2016
The project does not use libeio anymore. Remove disabled libeio-specific
test.

PR-URL: #7083
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@evanlucas evanlucas mentioned this pull request Jun 16, 2016
MylesBorins pushed a commit that referenced this pull request Jul 11, 2016
The project does not use libeio anymore. Remove disabled libeio-specific
test.

PR-URL: #7083
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
The project does not use libeio anymore. Remove disabled libeio-specific
test.

PR-URL: #7083
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
The project does not use libeio anymore. Remove disabled libeio-specific
test.

PR-URL: #7083
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@MylesBorins MylesBorins mentioned this pull request Jul 12, 2016
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
The project does not use libeio anymore. Remove disabled libeio-specific
test.

PR-URL: #7083
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
The project does not use libeio anymore. Remove disabled libeio-specific
test.

PR-URL: #7083
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@Trott Trott deleted the eio branch January 13, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants