doc: add information for IncomingMessage.destroy() #7237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
http
| * `error` {Error} | ||
|
|
||
| Calls `.destroy()` on the socket that received the `IncomingMessage`. If `error` | ||
| is provided, an `'error'` event is fired and `error` is passed as an argument to |
|
LGTM with a nit |
|
|
||
| * `error` {Error} | ||
|
|
||
| Calls `.destroy()` on the socket that received the `IncomingMessage`. If `error` |
There was a problem hiding this comment.
Can you remove the . from .destroy()
|
LGTM, also with a nit. |
Add documentation for `http.IncomingMessage.prototype.destroy()`. Fixes: nodejs#4226
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jun 12, 2016
Add documentation for `http.IncomingMessage.prototype.destroy()`. PR-URL: nodejs#7237 Fixes: nodejs#4226 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
|
Landed in 4f2aec3 |
|
@Trott is this relevant to v4.x? |
|
@thealphanerd Yes. |
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Jul 12, 2016
Add documentation for `http.IncomingMessage.prototype.destroy()`. PR-URL: nodejs#7237 Fixes: nodejs#4226 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc http
Description of change
Add documentation for
http.IncomingMessage.prototype.destroy().Fixes: #4226