Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tests for a some stream.Readable use cases #7260

Merged
merged 1 commit into from
Jun 18, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions test/parallel/test-stream-decoder-objectmode.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
'use strict';
require('../common');
const stream = require('stream');
const assert = require('assert');

const readable = new stream.Readable({
read: () => {},
encoding: 'utf16le',
objectMode: true
});

readable.push(Buffer.from('abc', 'utf16le'));
readable.push(Buffer.from('def', 'utf16le'));
readable.push(null);

// Without object mode, these would be concatenated into a single chunk.
assert.strictEqual(readable.read(), 'abc');
assert.strictEqual(readable.read(), 'def');
assert.strictEqual(readable.read(), null);
51 changes: 51 additions & 0 deletions test/parallel/test-stream-pipe-multiple-pipes.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
'use strict';
const common = require('../common');
const stream = require('stream');
const assert = require('assert');

const readable = new stream.Readable({
read: () => {}
});

const writables = [];

for (let i = 0; i < 5; i++) {
const target = new stream.Writable({
write: common.mustCall((chunk, encoding, callback) => {
target.output.push(chunk);
callback();
}, 1)
});
target.output = [];

target.on('pipe', common.mustCall(() => {}));
readable.pipe(target);


writables.push(target);
}

const input = Buffer.from([1, 2, 3, 4, 5]);

readable.push(input);

// The pipe() calls will postpone emission of the 'resume' event using nextTick,
// so no data will be available to the writable streams until then.
process.nextTick(common.mustCall(() => {
for (const target of writables) {
assert.deepStrictEqual(target.output, [input]);

target.on('unpipe', common.mustCall(() => {}));
readable.unpipe(target);
}

readable.push('something else'); // This does not get through.
readable.push(null);
readable.resume(); // Make sure the 'end' event gets emitted.
}));

readable.on('end', common.mustCall(() => {
for (const target of writables) {
assert.deepStrictEqual(target.output, [input]);
}
}));
12 changes: 12 additions & 0 deletions test/parallel/test-stream-readable-invalid-chunk.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
'use strict';
require('../common');
const stream = require('stream');
const assert = require('assert');

const readable = new stream.Readable({
read: () => {}
});

assert.throws(() => readable.push([]), /Invalid non-string\/buffer chunk/);
assert.throws(() => readable.push({}), /Invalid non-string\/buffer chunk/);
assert.throws(() => readable.push(0), /Invalid non-string\/buffer chunk/);
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
'use strict';
require('../common');
const stream = require('stream');
const assert = require('assert');

const readable = new stream.Readable();

assert.throws(() => readable.read(), /not implemented/);