Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: correct args for cluster message event #7297

Merged
merged 1 commit into from
Jun 15, 2016
Merged

doc: correct args for cluster message event #7297

merged 1 commit into from
Jun 15, 2016

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jun 14, 2016

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

This commit corrects the cluster message event signature.

Fixes: #5764

@cjihrig
doc: correct args for cluster message event
02a01bb 
This commit corrects the cluster message event signature.

Fixes: nodejs#5764
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 14, 2016
@cjihrig cjihrig mentioned this pull request Jun 14, 2016
Closed
@mscdex mscdex added cluster Issues and PRs related to the cluster subsystem. v4.x labels Jun 14, 2016
@mscdex
Copy link
Contributor

mscdex commented Jun 14, 2016 •
edited
Loading

LGTM.

On a semi-related note, it looks like the documentation for the worker's message event isn't documented correctly in all versions of the documentation (including master). It's missing a handle parameter after the actual message object parameter. The master's message event already has this parameter properly documented however.

@cjihrig cjihrig mentioned this pull request Jun 15, 2016
Merged
2 tasks
@cjihrig cjihrig merged commit 47f82cd into nodejs:v4.x-staging Jun 15, 2016
@cjihrig cjihrig deleted the docs branch June 15, 2016 14:32
cjihrig added a commit to cjihrig/node that referenced this pull request Jun 17, 2016
@cjihrig
doc: fix cluster worker 'message' event
62c8e7b 
This commit adds the missing handle argument to the cluster
worker 'message' event. It also adds a link to the process
'message' event for reference.

Refs: nodejs#7297
PR-URL: nodejs#7309
Reviewed-By: Brian White <mscdex@mscdex.net>
@MylesBorins MylesBorins mentioned this pull request Jun 24, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
@cjihrig
doc: correct args for cluster message event
98469ad 
This commit corrects the cluster message event signature.

Fixes: #5764
PR-URL: #7297
Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
@cjihrig
doc: correct args for cluster message event
b3e415f 
This commit corrects the cluster message event signature.

Fixes: #5764
PR-URL: #7297
Reviewed-By: Brian White <mscdex@mscdex.net>
evanlucas pushed a commit that referenced this pull request Jun 27, 2016
@cjihrig @evanlucas
doc: fix cluster worker 'message' event
12fbac1 
This commit adds the missing handle argument to the cluster
worker 'message' event. It also adds a link to the process
'message' event for reference.

Refs: #7297
PR-URL: #7309
Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@cjihrig
doc: fix cluster worker 'message' event
583a80d 
This commit adds the missing handle argument to the cluster
worker 'message' event. It also adds a link to the process
'message' event for reference.

Refs: #7297
PR-URL: #7309
Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@cjihrig
doc: fix cluster worker 'message' event
ad64d41 
This commit adds the missing handle argument to the cluster
worker 'message' event. It also adds a link to the process
'message' event for reference.

Refs: #7297
PR-URL: #7309
Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@cjihrig @MylesBorins
doc: fix cluster worker 'message' event
53f114d 
This commit adds the missing handle argument to the cluster
worker 'message' event. It also adds a link to the process
'message' event for reference.

Refs: #7297
PR-URL: #7309
Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@cjihrig
doc: fix cluster worker 'message' event
7a8fc1f 
This commit adds the missing handle argument to the cluster
worker 'message' event. It also adds a link to the process
'message' event for reference.

Refs: #7297
PR-URL: #7309
Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@cjihrig
doc: fix cluster worker 'message' event
21f13a3 
This commit adds the missing handle argument to the cluster
worker 'message' event. It also adds a link to the process
'message' event for reference.

Refs: #7297
PR-URL: #7309
Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@cjihrig
doc: fix cluster worker 'message' event
f51dd31 
This commit adds the missing handle argument to the cluster
worker 'message' event. It also adds a link to the process
'message' event for reference.

Refs: #7297
PR-URL: #7309
Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@cjihrig
doc: fix cluster worker 'message' event
75e4f74 
This commit adds the missing handle argument to the cluster
worker 'message' event. It also adds a link to the process
'message' event for reference.

Refs: #7297
PR-URL: #7309
Reviewed-By: Brian White <mscdex@mscdex.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cjihrig @mscdex @MylesBorins @nodejs-github-bot