benchmark: add more EventEmitter benchmarks #730
Conversation
|
You might also want to look at https://github.com/primus/eventemitter3/tree/master/benchmarks/run for additional benchmarks. |
|
|
||
| bench.start(); | ||
| for (var i = 0; i < n; i += 1) { | ||
| ee.emit('dummy', 5, true); |
There was a problem hiding this comment.
any chance we could do a varying range of argument length (i.e. 1-4) for this one? I'd say we could use .apply() since the benchmarks are only compared against eachother, really
There was a problem hiding this comment.
I don't care one way or the other. I just picked some number of arguments. I'm not sure if it'd be best to have a separate benchmark for one with tons of arguments or to lump them all into one....
There was a problem hiding this comment.
I was just thinking on the basis of your PR comment, and that it would be best to express that in a benchmark -- of course, this comment is pretty much only based on that PR, so thats up to you
PR-URL: #730 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
|
Thanks Brian, landed in 847b9d2 with Brendan as co-reviewer. |
No description provided.