Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix broken link in vm.md #7304

Closed
wants to merge 1 commit into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Jun 15, 2016

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Fixes a broken link to https://nodejs.org/api/vm.html#vm_what_does_it_mean_to_contextify_an_object.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 15, 2016
@lpinca lpinca force-pushed the fix/doc-internal-link branch from 8f69fa3 to 3e4f6f4 Compare June 15, 2016 06:27
@evanlucas
Copy link
Contributor

LGTM Thanks!

@claudiorodriguez
Copy link
Contributor

LGTM

@mscdex mscdex added the vm Issues and PRs related to the vm subsystem. label Jun 15, 2016
@silverwind
Copy link
Contributor

LGTM, this looks like a proper version of #7171.

@silverwind
Copy link
Contributor

Thanks! Landed in de9a841.

@silverwind silverwind closed this Jun 17, 2016
silverwind pushed a commit that referenced this pull request Jun 17, 2016
PR-URL: #7304
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@lpinca lpinca deleted the fix/doc-internal-link branch June 18, 2016 05:25
evanlucas pushed a commit that referenced this pull request Jun 27, 2016
PR-URL: #7304
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@Fishrock123 Fishrock123 mentioned this pull request Jun 27, 2016
@Fishrock123 Fishrock123 mentioned this pull request Jul 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants