Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Fs access doc clarity v6x #7321

Closed
wants to merge 2 commits into from
Closed

doc: Fs access doc clarity v6x #7321

wants to merge 2 commits into from

Conversation

lance
Copy link
Member

@lance lance commented Jun 16, 2016

Checklist
  • make -j4 test (UNIX) or vcbuild test nosign (Windows) passes
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Port doc/fs/api.md documentation changes to the v6.x branch. This change includes @jasnell's recent documentation changes regarding fs.constants. It is not clear to me if these changes should be included in the PR or not. If not, let me know and I'll update the PR.

Cherry picked from d976d66

Ref: #7113

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 16, 2016
@mscdex mscdex added fs Issues and PRs related to the fs subsystem / file system. v6.x labels Jun 16, 2016
@jasnell
Copy link
Member

jasnell commented Jun 20, 2016

The changes to constants have not yet landed in v6 so those doc changes should not be carried over yet.

These changes should not have been carried over from master.
@jasnell
Copy link
Member

jasnell commented Jun 20, 2016

LGTM

2 similar comments
@thefourtheye
Copy link
Contributor

LGTM

@cjihrig
Copy link
Contributor

cjihrig commented Jun 21, 2016

LGTM

jasnell pushed a commit that referenced this pull request Jun 21, 2016
Cherry picked from d976d66

PR-URL: #7321
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell
Copy link
Member

jasnell commented Jun 21, 2016

Landed in 1e7a7be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants