-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix link in the stream doc #7347
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
italoacasas
changed the title
Fixing link in streams docs
doc: fix link in the stream doc
Jun 21, 2016
Can you fix the spelling as well? I think it is supposed to be "API for Stream Implementers". cc @nodejs/documentation |
@thefourtheye is right, it should read “Implementers”. If you want to take a look at the others from #6947 (comment), you can to that too (I’d recommend rebasing against master first now that #7336 has landed). |
Ok i'll check the others and fix the typo. |
This is done. |
LGTM |
1 similar comment
LGTM |
Landed in 79f961a |
addaleax
pushed a commit
that referenced
this pull request
Jun 23, 2016
fixing typo fixing broken links PR-URL: #7347 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Fishrock123
pushed a commit
that referenced
this pull request
Jun 27, 2016
fixing typo fixing broken links PR-URL: #7347 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Merged
Fishrock123
pushed a commit
that referenced
this pull request
Jul 5, 2016
fixing typo fixing broken links PR-URL: #7347 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Merged
This was referenced Jul 1, 2023
This was referenced Jul 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
Fixing typo in the documentation.