Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix link in the stream doc #7347

Closed
wants to merge 3 commits into from
Closed

doc: fix link in the stream doc #7347

wants to merge 3 commits into from

Conversation

italoacasas
Copy link
Contributor

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Fixing typo in the documentation.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 21, 2016
@italoacasas italoacasas changed the title Fixing link in streams docs doc: fix link in the stream doc Jun 21, 2016
@mscdex mscdex added the stream Issues and PRs related to the stream subsystem. label Jun 21, 2016
@thefourtheye
Copy link
Contributor

Can you fix the spelling as well? I think it is supposed to be "API for Stream Implementers".

cc @nodejs/documentation

@addaleax
Copy link
Member

@thefourtheye is right, it should read “Implementers”.

If you want to take a look at the others from #6947 (comment), you can to that too (I’d recommend rebasing against master first now that #7336 has landed).

@italoacasas
Copy link
Contributor Author

Ok i'll check the others and fix the typo.

@italoacasas
Copy link
Contributor Author

italoacasas commented Jun 22, 2016

This is done.

@addaleax
Copy link
Member

LGTM

1 similar comment
@thefourtheye
Copy link
Contributor

LGTM

@addaleax
Copy link
Member

Landed in 79f961a

@addaleax addaleax closed this Jun 23, 2016
addaleax pushed a commit that referenced this pull request Jun 23, 2016
fixing typo
fixing broken links

PR-URL: #7347
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Jun 27, 2016
fixing typo
fixing broken links

PR-URL: #7347
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Jun 27, 2016
Fishrock123 pushed a commit that referenced this pull request Jul 5, 2016
fixing typo
fixing broken links

PR-URL: #7347
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Jul 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants