Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test for exec() known issue #7375

Closed
wants to merge 4 commits into from
Closed

test: add test for exec() known issue #7375

wants to merge 4 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 22, 2016

Checklist
  • make -j4 test (UNIX) or vcbuild test nosign (Windows) passes
  • a test and/or benchmark is included
  • the commit message follows commit guidelines
Affected core subsystem(s)

test child_process

Description of change

Refs: #7342

@Trott Trott added child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests. labels Jun 22, 2016
@Trott Trott mentioned this pull request Jun 22, 2016
Closed
@Trott
Copy link
Member Author

Trott commented Jun 22, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/3057/

@Trott Trott mentioned this pull request Jun 22, 2016
Closed
2 tasks
cjihrig
cjihrig reviewed Jun 22, 2016
View reviewed changes
test/known_issues/test-child-process-exec-stdout-data-string.js
const assert = require('assert');
const exec = require('child_process').exec;

const keepAlive = setInterval(() => {}, 9999);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't the child process keep the event loop open? Works for me locally without the timer.

@cjihrig
Copy link
Contributor

cjihrig commented Jun 22, 2016

LGTM with a couple comments.

@Trott
Copy link
Member Author

Trott commented Jun 23, 2016

@cjihrig Nits addressed. Also added a test for stderr. PTAL

@Trott
Copy link
Member Author

Trott commented Jun 23, 2016

CI again: https://ci.nodejs.org/job/node-test-pull-request/3061/

@cjihrig
Copy link
Contributor

cjihrig commented Jun 23, 2016

Changes LGTM

@santigimeno
Copy link
Member

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Jun 24, 2016
@Trott
test: add test for exec() known issue
c964574 
PR-URL: nodejs#7375
Refs: nodejs#7342
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@Trott
Copy link
Member Author

Trott commented Jun 24, 2016

Landed in c964574

@Trott Trott closed this Jun 24, 2016
Fishrock123 pushed a commit that referenced this pull request Jun 27, 2016
@Trott @Fishrock123
test: add test for exec() known issue
044a0be 
PR-URL: #7375
Refs: #7342
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Jun 27, 2016
Merged
Fishrock123 pushed a commit that referenced this pull request Jul 5, 2016
@Trott @Fishrock123
test: add test for exec() known issue
16aff79 
PR-URL: #7375
Refs: #7342
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Jul 5, 2016
Merged
@MylesBorins MylesBorins mentioned this pull request Jul 11, 2016
Closed
@MylesBorins
Copy link
Contributor

@Trott lts?

@Trott
Copy link
Member Author

Trott commented Jul 12, 2016

@thealphanerd If it lands and CI's cleanly, yes.

MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@Trott
test: add test for exec() known issue
91001cc 
PR-URL: #7375
Refs: #7342
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@Trott
test: add test for exec() known issue
5735a3d 
PR-URL: #7375
Refs: #7342
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 12, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@Trott
test: add test for exec() known issue
d7d9990 
PR-URL: #7375
Refs: #7342
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@Trott
test: add test for exec() known issue
a31d316 
PR-URL: #7375
Refs: #7342
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@Trott Trott deleted the known-exec branch January 13, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trott @cjihrig @santigimeno @MylesBorins