Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add CTC meeting minutes 2016-06-22 #7390

Closed
wants to merge 1 commit into from

Conversation

joshgav
Copy link
Contributor

@joshgav joshgav commented Jun 23, 2016

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

add CTC meeting minutes 2016-06-22
closes #7366

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 23, 2016
@joshgav
Copy link
Contributor Author

joshgav commented Jun 23, 2016

@bmeck @jdalton - can you check line 141, i.e. the second semantic difference between CJS/ES6?

@bzoz - In talking with @joaocgreis this morning it seems the proposed fs.realpath fix by @trevnorris might not address Windows path issues such as #7294. Can you check?

/cc @nodejs/ctc

@bzoz
Copy link
Contributor

bzoz commented Jun 24, 2016

@joshgav: to fix #7294 and make fs.realpath behave as before under Windows I would need to revert to old js code for that specific case. I don't know how @trevnorris wants to implement this, but falling back to old implementation in case of errors or corner cases would solve it.

@bmeck
Copy link
Member

bmeck commented Jun 24, 2016

@joshgav , lgtm

On Fri, Jun 24, 2016 at 5:24 AM, Bartosz Sosnowski <notifications@github.com

wrote:

@joshgav https://github.com/joshgav: to fix #7294
#7294 and make fs.realpath behave
as before under Windows I would need to revert to old js code for that
specific case. I don't know how @trevnorris
https://github.com/trevnorris wants to implement this, but falling back
to old implementation in case of errors or corner cases would solve it.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#7390 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAOUoyxYR51pTkcQG3vY2nu3sch1GB2zks5qO7BagaJpZM4I9FgE
.

@rvagg
Copy link
Member

rvagg commented Jun 27, 2016

lgtm, thanks @joshgav!

@jasnell
Copy link
Member

jasnell commented Aug 1, 2016

LGTM

jasnell pushed a commit that referenced this pull request Aug 1, 2016
closes #7366

PR-URL: #7390
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Aug 1, 2016

Landed in 6d9a500

@jasnell jasnell closed this Aug 1, 2016
@joshgav joshgav deleted the june-22-ctc-meeting branch August 3, 2016 21:31
@cjihrig cjihrig mentioned this pull request Aug 8, 2016
cjihrig pushed a commit that referenced this pull request Aug 10, 2016
closes #7366

PR-URL: #7390
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig cjihrig mentioned this pull request Aug 11, 2016
MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
closes #7366

PR-URL: #7390
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
closes #7366

PR-URL: #7390
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
closes #7366

PR-URL: #7390
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node.js Foundation Core Technical Committee (CTC) Meeting 2016-06-22
7 participants