-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add v8 requirement to test-v8* in Makefile #7482
Conversation
The test targets expect that V8 is built in deps/v8/out Ref: nodejs#7477
I was just about to submit this, testing locally. LGTM |
Without this it would always compile Release and Debug builds.
I added a second commit to use the BUILDTYPE variable in cc @exinfinitum who can maybe explain why it was done differently. |
LGTM |
@thealphanerd LGTY with the second commit ? |
@targos what is the build type variable used for? |
If we don't specify the build type, both Release and Debug builds will be compiled (you can see it here). |
LGTM |
The test targets expect that V8 is built in deps/v8/out Ref: nodejs#7477 PR-URL: nodejs#7482 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Without this it would always compile Release and Debug builds. Ref: nodejs#7477 PR-URL: nodejs#7482 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
@targos this is not landing cleanly on v4.x would you be willing to backport |
Checklist
Affected core subsystem(s)
build
Description of change
The test targets expect that V8 is built in deps/v8/out
Ref: #7477