Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add added: information for timers #7493

Closed
wants to merge 1 commit into from
Closed

doc: add added: information for timers #7493

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Ref: #6578

@addaleax addaleax added doc Issues and PRs related to the documentations. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. labels Jun 30, 2016
@sam-github sam-github mentioned this pull request Jun 30, 2016
Closed
36 tasks
Fishrock123
Fishrock123 reviewed Jun 30, 2016
View reviewed changes
doc/api/timers.md
@@ -94,6 +106,9 @@ set to `1`.
If `callback` is not a function, a [`TypeError`][] will be thrown.

### setTimeout(callback, delay[, ...arg])
<!-- YAML
added: v0.0.1
Copy link
Contributor

@Fishrock123 Fishrock123 Jun 30, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem quite right?

I'm pretty sure Isaac added these but that wasn't at the start I think...

The oldest reference I seem to be able to find of it exposed on the global (actually GLOBAL at the time) is 7a2e784 (v0.1.16)

hmmm, Indeed it looks like the original was added before v0.0.1 but I'm not sure it was exposed in a way that uh, counts?

.. also note that (awkwardly) these were actually added to the timers module pretty long after they were available on the global object. They were added to the module in 7994400 (v0.3.1)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The oldest reference I seem to be able to find of it exposed on the global (actually GLOBAL at the time) is 7a2e784 (v0.1.16)

It was present on the global before; the JS entry point (src/node.js) is executed without the function wrapper, so the functions defined there became part of the global scope.

If you prefer, I can go for the version in which they were added to the timers module, but that’s not the common usage pattern (not that it really matters too much for this old stuff anyway).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¯_(ツ)_/¯

@Fishrock123
Copy link
Contributor

LGTM

1 similar comment
@jasnell
Copy link
Member

jasnell commented Jun 30, 2016

LGTM

@addaleax
Copy link
Member Author

addaleax commented Jul 5, 2016

Landed in cd4dbf3

@addaleax addaleax closed this Jul 5, 2016
@addaleax addaleax deleted the add-added-timers branch July 5, 2016 19:50
addaleax added a commit that referenced this pull request Jul 5, 2016
@addaleax
doc: add added: information for timers
cd4dbf3 
Ref: #6578
PR-URL: #7493
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Jul 6, 2016
@addaleax @Fishrock123
doc: add added: information for timers
b0da07a 
Ref: #6578
PR-URL: #7493
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Jul 6, 2016
Merged
@MylesBorins MylesBorins mentioned this pull request Jul 11, 2016
Closed
addaleax added a commit to addaleax/node that referenced this pull request Jul 12, 2016
@addaleax
doc: add added: information for timers
cd43026 
Ref: nodejs#6578
PR-URL: nodejs#7493
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@addaleax
doc: add added: information for timers
622929f 
Ref: #6578
PR-URL: #7493
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@addaleax
doc: add added: information for timers
aeb1747 
Ref: #6578
PR-URL: #7493
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 12, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@addaleax
doc: add added: information for timers
8bbeaa4 
Ref: #6578
PR-URL: #7493
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@addaleax
doc: add added: information for timers
88f46b8 
Ref: #6578
PR-URL: #7493
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@addaleax @Fishrock123 @jasnell @MylesBorins