-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http: add host and port info to ECONNRESET errors #7498
Conversation
LGTM if CI is green |
Documentation for these new properties should probably be added here: https://github.com/nodejs/node/blame/master/doc/api/errors.md#L481-L484 |
c.end(); | ||
}); | ||
|
||
server.listen(common.PIPE, () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is common.PIPE
in here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lines 179 to 186 in 15157c3
if (exports.isWindows) { | |
exports.PIPE = '\\\\.\\pipe\\libuv-test'; | |
if (process.env.TEST_THREAD_ID) { | |
exports.PIPE += '.' + process.env.TEST_THREAD_ID; | |
} | |
} else { | |
exports.PIPE = exports.tmpDir + '/test.sock'; | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add common.mustCall()
to this callback.
LGTM with CI: https://ci.nodejs.org/job/node-test-commit/3968/ |
Looks like this fell by the wayside .... New CI run: https://ci.nodejs.org/job/node-test-pull-request/3549/ |
|
||
common.refreshTmpDir(); | ||
|
||
var server = net.createServer((c) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use const
here.
b6f2258
to
ebc53e0
Compare
@cjihrig Thank you for the feedback. I just pushed the fixes. |
Thanks, LGTM. CI: https://ci.nodejs.org/job/node-test-pull-request/3623/ |
looks like possibly some linting issues? |
ebc53e0
to
fcf4623
Compare
@jasnell thanks for the heads up. I was able to run the linter on my side and fixed the issue. |
New CI: https://ci.nodejs.org/job/node-test-pull-request/3740/ (sorry for the delay) |
@jfromaniello ... can I ask you to make one additional change here to make it consistent with the change you did in your other PR ==> #7476 (comment) |
Looking forward to this one landing, anything I can do to help? |
ping @jfromaniello |
@jasnell Just fixed the indentation as you suggested on the other PR. What else could I do in this PR? |
fcf4623
to
50221cf
Compare
c133999
to
83c7a88
Compare
Looks like this one slipped through the cracks! New CI: https://ci.nodejs.org/job/node-test-pull-request/5735/ |
@jasnell @jfromaniello it looks like the linter and test/arm failure Details links go to 404 pages. Any chance we can get another run to replace the 404? I'd love to know what's left to fix to get this merged (and help if I can). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jfromaniello can you run make lint
locally? That's the only thing that failed on the CI. Other than that, LGTM.
ping @jfromaniello Do you want to look into the the linter errors? Thanks |
Add more information to the "ECONNRESET" errors generated when the socket hang ups before receiving the response. These kind of errors are really hard to troubleshoot without this info.
50221cf
to
c995420
Compare
Last CI was three months ago, I will land this today if CI passes: https://ci.nodejs.org/job/node-test-pull-request/8656/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR needs to be adapted to some recent changes in _http_client.js
(see CI failures). Namely, the variable self
is not defined anymore.
I am closing this due to inactivity, feel free to reopen (or ping me). |
Checklist
make -j4 test
(UNIX), orvcbuild test nosign
(Windows) passesAffected core subsystem(s)
http
Description of change
Add more information to the "ECONNRESET" errors generated on HTTP when the
socket hang ups before receiving a response.
These kind of errors are really hard to troubleshoot without this info.
This change is similar to #7476.