build: add --enable-d8 configure option

[bnoordhuis]

Add an option to the configure script for building d8. Useful for
testing V8 standalone.

[addaleax]

LGTM with (normal) CI: https://ci.nodejs.org/job/node-test-commit/3973/

[jasnell]

LGTM

[rvagg]

where does the binary land?

is this something we might want to not publicise in ./configure --help? it's yet another thing people will come to us for support with but is not within the scope of what we're shipping, go to the V8 project if you want d8.

[jasnell]

I would vote for a silent, undocumented option. This is something I've
found myself wanting on multiple occasions for my own debugging but it's
definitely not something I'd like to have to provide support for
On Jul 5, 2016 5:55 PM, "Rod Vagg" notifications@github.com wrote:

where does the binary land?

is this something we might want to not publicise in ./configure --help?
it's yet another thing people will come to us for support with but is not
within the scope of what we're shipping, go to the V8 project if you want
d8.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#7538 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAa2eb4lfHGbn6ruwlifGrP7QStcToxUks5qSv0dgaJpZM4JFKyX
.

[bnoordhuis]

@jasnell @rvagg The binary ends up in out/$BUILDTYPE, like other binaries. I've undocumented the switch. LGTY?

[jasnell]

Lgtm
On Jul 6, 2016 7:27 AM, "Ben Noordhuis" notifications@github.com wrote:

@jasnell https://github.com/jasnell @rvagg https://github.com/rvagg
The binary ends up in out/$BUILDTYPE, like other binaries. I've
undocumented the switch. LGTY?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#7538 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAa2eYr9TOEqHlVAIEhXGSGzjIGxn4CUks5qS7tvgaJpZM4JFKyX
.

[rvagg]

lgtm!

[gibfahn]

@rvagg @jasnell Would it be possible to have a section of the documentation for unstable and unsupported options? This seems like a useful feature for node debugging.

[bnoordhuis]

@gibfahn I'd be alright with a HACKING.md or whatever you want to call it in doc/.

[MylesBorins]

@bnoordhuis lts?

[rvagg]

@thealphanerd yes this would be helpful in v4

[MylesBorins]

this does not land cleanly on v4.x @bnoordhuis would you be willing to backport?

[bnoordhuis]

#7704