Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix detached child stdio example #7540

Merged
merged 1 commit into from
Jul 6, 2016
Merged

doc: fix detached child stdio example #7540

merged 1 commit into from
Jul 6, 2016

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jul 5, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

The example uses ['ignore'], where 'ignore' is intended. This commit drops the extra braces.

Fixes: #7269

@nodejs-github-bot nodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. labels Jul 5, 2016
@addaleax
Copy link
Member

addaleax commented Jul 5, 2016

LGTM

1 similar comment
@jasnell
Copy link
Member

jasnell commented Jul 5, 2016

LGTM

@cjihrig
doc: fix detached child stdio example
5a571a5 
The example changed by this commit uses ['ignore'] where
'ignore' is intended.

Fixes: nodejs#7269
PR-URL: nodejs#7540
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig cjihrig merged commit 5a571a5 into nodejs:master Jul 6, 2016
@cjihrig cjihrig deleted the 7269 branch July 6, 2016 16:02
@MylesBorins MylesBorins mentioned this pull request Jul 11, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@cjihrig
doc: fix detached child stdio example
6128758 
The example changed by this commit uses ['ignore'] where
'ignore' is intended.

Fixes: #7269
PR-URL: #7540
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@cjihrig @MylesBorins
doc: fix detached child stdio example
efca61e 
The example changed by this commit uses ['ignore'] where
'ignore' is intended.

Fixes: #7269
PR-URL: #7540
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this pull request Jul 12, 2016
@cjihrig @evanlucas
doc: fix detached child stdio example
b454734 
The example changed by this commit uses ['ignore'] where
'ignore' is intended.

Fixes: #7269
PR-URL: #7540
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@cjihrig
doc: fix detached child stdio example
f64c9b6 
The example changed by this commit uses ['ignore'] where
'ignore' is intended.

Fixes: #7269
PR-URL: #7540
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@cjihrig
doc: fix detached child stdio example
38248c6 
The example changed by this commit uses ['ignore'] where
'ignore' is intended.

Fixes: #7269
PR-URL: #7540
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 12, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@cjihrig
doc: fix detached child stdio example
90d36c8 
The example changed by this commit uses ['ignore'] where
'ignore' is intended.

Fixes: #7269
PR-URL: #7540
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@cjihrig
doc: fix detached child stdio example
186af29 
The example changed by this commit uses ['ignore'] where
'ignore' is intended.

Fixes: #7269
PR-URL: #7540
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@evanlucas evanlucas mentioned this pull request Jul 18, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cjihrig @addaleax @jasnell @MylesBorins @nodejs-github-bot