Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: export openssl symbols on windows (v4.x) #7676

Closed
wants to merge 205 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
205 commits
Select commit Hold shift + click to select a range
e4690c2
build: add --enable-d8 configure option
bnoordhuis Jul 5, 2016
f6bcfcf
test: add --repeat option to tools/test.py
mhdawson May 11, 2016
0ce75ff
build: add node_module_version to config.gypi
saper Jul 20, 2016
82f2f01
doc: improve server.listen() random port
phillipj Aug 8, 2016
008e596
test: exclude tests for AIX
mhdawson Aug 11, 2016
5e14465
doc: grammar fixes to event loop guide
ryanmurakami Jun 29, 2016
0c20cdb
net: export isIPv4, isIPv6 directly from cares
thefourtheye Jun 29, 2016
ee3c955
util: inspect boxed symbols like other primitives
addaleax Jul 9, 2016
77827eb
deps: `MASM.UseSafeExceptionHandlers` for OpenSSL
indutny Jun 26, 2016
83f0544
deps: no /safeseh for ml64.exe
indutny Jul 16, 2016
04e5f75
doc: add `added:` info for dgram.*Membership()
Trott May 16, 2016
f3ae5c5
lib: implement consistent brace style
Trott Jul 9, 2016
a8cedcb
test: implement consistent braces
Trott Jul 9, 2016
fa3ec3d
tools: enforce JS brace style with linting
Trott Jul 9, 2016
9ffc808
net: make holding the buffer in memory more robust
addaleax Aug 24, 2016
401b4ff
src: use RAII for mutexes and condition variables
bnoordhuis Jun 17, 2016
1ee0404
tools: increase lint coverage
Trott Jul 10, 2016
9692a8b
doc: add POST_STATUS_TO_PR info to onboarding doc
Trott Aug 10, 2016
f5dcfd8
doc: minor updates to onboarding doc
Trott Aug 10, 2016
fea4a1c
doc: delete non-existing zlib constants
fhinkel Jul 2, 2016
8aea06e
doc: fix util.deprecate() example
evanlucas Jul 12, 2016
304e7ae
doc: update CTC governance information
Trott Jul 13, 2016
1b89bb8
doc: update readme with andrasq as a collaborator
Jul 19, 2016
4573617
doc: clarify that the node.js irc channel is not under tsc oversight
jasnell Jul 20, 2016
ad9cedf
doc: add princejwesley to collaborators
princejwesley Jul 26, 2016
c2dce10
doc: remove platform assumption from CONTRIBUTING
BethGriggs Jul 18, 2016
cbc3296
doc: add information about CTC quorum rules
Trott Jul 20, 2016
99b8013
meta: provide example activities
Trott Jul 15, 2016
9a94f46
doc: add CTC meeting minutes 2016-07-27
williamkapke Jul 27, 2016
def8a72
meta: include a minimal CTC removal policy
Trott Jul 13, 2016
6dee633
doc: add CTC meeting minutes 2016-06-29
joshgav Jul 6, 2016
3ee9994
doc: add CTC meeting minutes 2016-07-06
joshgav Jul 6, 2016
d0dd117
doc: add @addaleax to the CTC
addaleax Aug 3, 2016
0ac801a
doc: piscisaureus has stepped-down from the CTC
jasnell Aug 3, 2016
796556a
doctool: improve the title of pages in doc
yorkie Aug 1, 2016
23989b0
doc: use `git-secure-tag` for release tags
indutny Jul 23, 2016
d21db24
meta: clarify process for breaking changes
Trott Aug 3, 2016
2efd86c
doc: use consistent markdown in README
Trott Aug 3, 2016
5cff784
doc: add CTC meeting minutes 2016-07-20
joshgav Aug 3, 2016
7d708da
doc: add CTC meeting minutes 2016-07-13
joshgav Aug 3, 2016
2ea6a02
tools: add .vscode folder to .gitignore
joshgav Aug 3, 2016
1a85ce2
doc: clarify "Reviewed-By" iff "LGTM"
bengl Jun 6, 2016
cce91d7
doc: clarify collaborators & ctc members relationships
yorkie Aug 6, 2016
40322c4
tools: add remark-lint configuration in .remarkrc
ChALkeR Jul 14, 2016
f152e8f
doc: fix a markdown error in CTC meeting minutes
ChALkeR Aug 5, 2016
7188559
doc: add CTC meeting minutes 2016-08-03
joshgav Aug 4, 2016
cfed8e6
doc: Add fhinkel to collaborators
fhinkel Aug 10, 2016
ca1738e
doc: move orangemocha to collaborators list
Trott Aug 11, 2016
717372d
doc: update Reviewing section of onboarding doc
Trott Aug 12, 2016
3c561da
doc: add @joshgav to collaborators
joshgav Aug 17, 2016
de78989
doc: update release announce instruction to tweet
hackygolucky Aug 16, 2016
d9954cf
doc: remove outdated LTS info from ROADMAP.md
Trott Aug 18, 2016
4cc7fea
doc: remove "feature branch" jargon
Trott Aug 20, 2016
a1490a5
test,doc: clarify `buf.indexOf(num)` input range
addaleax Jul 8, 2016
85c0235
test: add test for assert.notStrictEqual()
Trott Aug 13, 2016
f98a94b
test: add uncaught exception test for debugger
Trott Aug 12, 2016
855a738
test: fix flaky test-*-connect-address-family
Trott Jul 8, 2016
1420537
test: accept expected AIX result test-stdio-closed
Trott Sep 23, 2016
34b3a03
test: handle IPv6 localhost issues within tests
Trott Jul 16, 2016
1924a18
win,msi: Added Italian translation
mcollina Jan 12, 2016
4ca798b
win,msi: add zh-CN translations for the installer
pmq20 Jul 14, 2016
d22472a
test: add common.rootDir
cjihrig Jul 12, 2016
f62f99d
cluster: remove bind() and self
cjihrig Jul 13, 2016
92c399c
test: s/assert.fail/common.fail as appropriate
cjihrig Jul 14, 2016
f2916f8
buffer: optimize hex_decode
chjj Jul 7, 2016
2aaa755
test: clean up test-buffer-badhex
Fishrock123 Jul 17, 2016
59a0213
doc: correct sample output of buf.compare
khalsah Jul 17, 2016
8d55fe1
test: avoid usage of mixed IPV6 addresses
gireeshpunathil Jul 13, 2016
99fdb9f
test: ensure stream preprocessing order
vsemozhetbyt Jul 14, 2016
ab066d7
doc: remove extra spaces and concats in examples
joeyespo Jul 27, 2016
a68d958
tools,test: show signal code when test crashes
santigimeno Jul 24, 2016
b9fce21
test: decrease inconsistency in the common.js
vsemozhetbyt Jul 16, 2016
ea28d62
doc: add CTC meeting minutes 2016-06-22
joshgav Jun 23, 2016
b3634ad
win,msi: fix inclusion of translations
joaocgreis Jul 19, 2016
59d2efe
doc: Clean up roff source in manpage
Alhadis Jul 21, 2016
a2804ed
deps: float gyp patch for long filenames
addaleax May 27, 2016
664eb68
build: turn on thin static archives
bnoordhuis Aug 3, 2016
0f9d7fd
doc: fix cluster message event docs
zbjornson Aug 8, 2016
4ff7d93
tools: favor === over == in license2rtf.js
Trott Aug 11, 2016
68a2979
readline: keypress trigger for escape character
princejwesley Jun 23, 2016
5febcca
doc: fix variable scoping bug in server example code
lazlojuly Aug 16, 2016
ce2ca5e
url: `url.format()` encodes all `#` in `search`
imyller Aug 11, 2016
256066c
configure: reword help for --without-npm
BlackYoup Jun 29, 2016
74f76f6
debugger: use arrow function for lexical `this`
originalfoo Jun 25, 2016
ab6e771
test: add test for attempted multiple IPC channels
cjihrig Aug 18, 2016
fa5a12d
doc: use blockquotes for Stability: markers
addaleax Jul 15, 2016
28d2271
doc: add `added:` information for cluster
addaleax Jul 9, 2016
ccc48f4
src: don't include a null character in the WriteConsoleW call
seishun Jul 16, 2016
ade85c6
doc: add Myles Borins to the CTC
rvagg Aug 24, 2016
0e94765
async_wrap: add a missing case to test-async-wrap-throw-no-init
yorkie Aug 20, 2016
3345aab
build: fix dependencies on AIX
mhdawson Aug 25, 2016
4010cd6
test: add check in test-signal-handler
Trott Aug 24, 2016
7732863
doc: add `added:` information for modules
lpinca Aug 24, 2016
3a50f84
build: fix dependencies on AIX
mhdawson Aug 26, 2016
21834df
doc: readline write() is processed as input
jasnell Aug 27, 2016
5fd15cf
test: refactor test-debug-signal-cluster
Trott Aug 26, 2016
f21794b
doc: add lpinca to collaborators
lpinca Aug 30, 2016
eb3b59b
test: add test for zlib.create*Raw()
Trott Aug 28, 2016
300c3e3
doc: adding danbev to collaborators
danbev Aug 30, 2016
99df574
build: don't require processing docs for nightlies
jbergstroem Aug 29, 2016
48e7a2b
doc: bad/better examples for fs.access() and fs.exists()
dfabulich Jul 22, 2016
d927b69
doc: update landing pr info in onboarding doc
Trott Aug 30, 2016
9b2b6a4
test: fix ::1 error in test-dns-ipv6
gibfahn Aug 26, 2016
f0f67c1
doc: update targos email in readme per request
jasnell Sep 2, 2016
8bcf2d3
test: test non-buffer/string with zlib
Trott Aug 31, 2016
9c05528
doc: add return type of clientRequest.setTimeout
MikeRalphson Aug 31, 2016
c3601ce
doc: update authors list
jasnell Aug 30, 2016
a80a753
doc: update CI content in onboarding doc
Trott Sep 1, 2016
27bb407
test: mark pseudo-tty/no_dropped_stdio as flaky
mhdawson Sep 2, 2016
38c43ae
doc: add 2016-08-10 CTC meeting minutes
joshgav Aug 22, 2016
e9d7926
doc: add 2016-08-17 CTC meeting minutes
joshgav Aug 23, 2016
23e090b
doc: add CI help/support info to onboarding doc
Trott Sep 5, 2016
308c8de
url: fix inconsistent port in url.resolveObject
imyller Aug 21, 2016
94fe34c
benchmark: add benches for fs.stat & fs.statSync
addaleax Aug 30, 2016
05a8862
test: add test-debug-protocol-execute
Trott Sep 8, 2016
fced288
url: fix off-by-one error in loop handling dots
lpinca Sep 6, 2016
9e8d1c7
test: clean up net server try ports test
tlhunter Sep 9, 2016
2c31e5b
test: skip pseudo-tty/no_dropped_stdio test
mhdawson Sep 9, 2016
d96c3ea
doc: add CTC meeting minutes 2016-08-31
joshgav Sep 6, 2016
c0f79da
test: swapped == and equal to === and strictEqual
HyperSprite Sep 9, 2016
48d64fc
doc: update exercise portion of onboarding doc
Trott Sep 16, 2016
fbf54ca
doc: add link to help repo in README
Trott Sep 17, 2016
4bbf078
doc: add ak239 to collaborators
alexkozy Sep 20, 2016
58fd23c
doc: add eugeneo to collaborators
Sep 21, 2016
e76eb6e
doc: add CTC meeting minutes 2016-08-24
joshgav Sep 6, 2016
bc93487
doc: add commit formats for release blog posts
Sep 17, 2016
8d97ad1
doc: encourage 2FA before onboarding
Trott Sep 25, 2016
a93011c
doc: update onboarding PR landing info
Trott Sep 10, 2016
566f3b9
doc: add not-an-aardvark to collaborators
not-an-aardvark Sep 13, 2016
7d6ce04
test: fix flaky test-force-repl
Trott Sep 10, 2016
8f5df1d
doc: add imyller to collaborators
imyller Sep 14, 2016
9cdc123
doc: add gibfahn to collaborators
gibfahn Sep 14, 2016
328693b
doc: add `added:` information for events
lpinca Jul 21, 2016
383419f
doc: add `added:` information for util
lpinca Aug 21, 2016
b061ab9
doc: add `added:` information for dgram
lpinca Aug 20, 2016
2fd78af
doc: add `added:` information for crypto
lpinca Aug 26, 2016
4cb37ae
child_process: workaround fd passing issue on OS X
santigimeno Jun 16, 2016
f11577b
deps: upgrade npm in LTS to 2.15.11
zkat Oct 4, 2016
2c8e237
doc: update npm LICENSE using license-builder.sh
zkat Oct 4, 2016
5186253
test: refector parallel/test-http.js
jun-oka Sep 9, 2016
cc607b1
test: add coverage for client._addHandle()
Trott Sep 13, 2016
52aac97
test: improve test-https-agent.js
Williams-Dan Sep 13, 2016
0500c49
test: add tests for add/remove header after sent
niklasi Sep 20, 2016
81e60f4
test: stream writable ended state
italoacasas Sep 27, 2016
4bb8028
doc: add CTC meeting minutes 2016-09-21
joshgav Sep 22, 2016
3e61dad
doc: add CTC meeting minutes 2016-09-14
joshgav Sep 22, 2016
c7af247
doc: add CTC meeting minutes 2016-09-07
joshgav Sep 12, 2016
d43be58
build: adding config.gypi dep to addons/.buildstamp
danbev Jul 27, 2016
4da9ddd
doc: add `added:` information for globals
lpinca Oct 3, 2016
e9ef643
test: fix `fs-watch-recursive` flakiness on OS X
santigimeno Jan 11, 2016
a9b249f
build: re-add --ninja option to configure
ehsan May 16, 2016
b06323c
intl: Don't crash if v8BreakIterator not available
srl295 Oct 10, 2016
a201795
repl: Enable tab completion for global properties
lance Jun 22, 2016
cfac04e
deps: cherry-pick 1f53e42 from v8 upstream
bnoordhuis Jul 7, 2016
b613d2a
test: move parallel/test-tty-* to pseudo-tty/
Fishrock123 Jul 8, 2016
7a100b3
test: fix old tty tests
Fishrock123 Jul 8, 2016
072fab4
build: add conflict marker check during CI lint
mscdex Jul 8, 2016
91d3fea
test: improve error message in test-tick-processor
Trott Jul 12, 2016
5d8b132
test: mark test-child-process-fork-dgram as flaky
mhdawson Aug 25, 2016
6b191f3
deps: backport e093a04, 09db540 from upstream V8
ofrobots Apr 15, 2016
2cfec2d
deps: cherry-pick b93c80a from v8 upstream
Jul 12, 2016
b6692ba
deps: backport a76d133 from v8 upstream
Jul 20, 2016
e025805
dns: tweak regex for IPv6 addresses
lpinca Sep 20, 2016
a2c9444
test: improve coverage of the util module
targos Oct 7, 2016
f8b32d9
test: fix flaky test-http-server-consumed-timeout
Trott Jul 13, 2016
552d984
build: don't link against liblog on host system
bnoordhuis Jul 16, 2016
cfafda1
test: increase RAM requirement for intensive tests
Trott Jul 17, 2016
004d665
deps: backport 2bcbe2f from V8 upstream
ofrobots Jun 7, 2016
680f270
test: speed up test-net-reconnect-error
Trott Jul 27, 2016
49a0e87
test: console constructor missing new keyword
Trott Aug 7, 2016
3b126df
test: add test for debug usage message
Trott Aug 10, 2016
5f74551
build: add missing files to zip and 7z packages
richardlau Aug 11, 2016
9e7a386
test: use strict equality in regression test
Trott Aug 14, 2016
7394ede
net: remove unnecessary variables
mscdex Aug 15, 2016
084d899
net: add length check when normalizing args
mscdex Aug 15, 2016
96d7ff8
test: fix assertion in test-watch-file.js
Trott Aug 16, 2016
a194574
test: favor strict equality check
Trott Aug 16, 2016
137d10d
test: favor `===` over `==` in test-timers.js
Trott Aug 16, 2016
bc3fa4d
assert: remove code that is never reached
Trott Aug 16, 2016
ea65d4d
test: confirm that assert truncates long values
Trott Aug 17, 2016
3702f1f
test: favor strict equality in pummel net tests
Trott Aug 17, 2016
ba7c13b
test: favor strict equality in http tests
Trott Aug 17, 2016
83865bd
test: add missing assert.deepEqual() test case
Trott Aug 17, 2016
2d82031
test: add assert.notDeepEqual() tests
Trott Aug 18, 2016
7ca1fcd
test: favor strict equality in test-exec
Trott Aug 18, 2016
451b5f9
test: refactor pummel/test-dtrace-jsstack
Trott Aug 18, 2016
30d84f6
test: favor `===` over `==` in crypto tests
Trott Aug 18, 2016
275386e
test: add assert.notDeepStrictEqual() tests
Trott Aug 19, 2016
ec99640
test: refactor test-tick-processor
Trott Aug 19, 2016
e8aa558
doc/json: make sure links are correctly passed to marked
TimothyGu Aug 30, 2016
c795494
doc: add missing semicolon
ravindrabarthwal Jul 29, 2016
75a40d1
doc: fix broken link in dgram doc
mscdex Sep 1, 2016
bc8431e
win,build: fail on invalid option in vcbuild
joaocgreis Sep 1, 2016
91a23b1
win,build: skip finding VS when not needed
joaocgreis Sep 4, 2016
18f0348
win,build: exit when addons fail to build
joaocgreis Sep 5, 2016
1b318e8
win,build: forward release_urlbase to configure
joaocgreis Sep 7, 2016
2847490
tls: copy the Buffer object before using
thefourtheye Aug 10, 2016
961b354
src: fix handle leak in Buffer::New()
bnoordhuis Jul 13, 2016
11f1da8
src: fix handle leak in BuildStatsObject()
bnoordhuis Jul 13, 2016
d6cac6d
src: fix handle leak in UDPWrap::Instantiate()
bnoordhuis Jul 13, 2016
6f3ac5d
src: remove unnecessary HandleScopes
bnoordhuis Jul 13, 2016
1f900b6
deps: avoid single-byte buffer overwrite
bagder Sep 23, 2016
f820e02
build: run `npm install` for doc builds in tarball
addaleax Sep 5, 2016
c97d1c2
build: export openssl symbols on windows
bnoordhuis Apr 18, 2016
5087643
build: export more openssl symbols on Windows
Jul 10, 2016
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc: add POST_STATUS_TO_PR info to onboarding doc
`POST_STATUS_TO_PR` previously did not work.

Now it works.

Update the onboarding documentation accordingly.

PR-URL: #8059
Reviewed-By: Anna Henningsen <anna@addaleax.net>
  • Loading branch information
Trott authored and Myles Borins committed Sep 28, 2016
commit 9692a8bb554832fa34177a49449f95536088c090
3 changes: 1 addition & 2 deletions doc/onboarding.md
Original file line number Diff line number Diff line change
@@ -110,8 +110,7 @@ Ensure everyone is added to https://github.com/orgs/nodejs/teams/collaborators
* To start CI testing from this screen, you need to fill in two elements on the form:
* The `CERTIFY_SAFE` box should be checked. By checking it, you are indicating that you have reviewed the code you are about to test and you are confident that it does not contain any malicious code. (We don't want people hijacking our CI hosts to attack other hosts on the internet, for example!)
* The `PR_ID` box should be filled in with the number identifying the pull request containing the code you wish to test. For example, if the URL for the pull request is https://github.com/nodejs/node/issues/7006, then put `7006` in the `PR_ID`.
* The remaining elements on the form are typically unchanged.
* There is a checkbox for `POST_STATUS_TO_PR`. At the time of this writing, that checkbox does not do anything, but that is likely to change soon. Until that functionality is working, you will want to go back to the PR you are testing and paste `CI: <URL-of-the-CI-test-run>` into a comment on the pull request.
* The remaining elements on the form are typically unchanged with the exception of `POST_STATUS_TO_PR`. Check that if you want a CI status indicator to be automatically inserted into the PR.


### process for getting code in: