deps: cherry-pick 6f68f30 from v8 upstream #7802

stefanmb · 2016-07-20T01:06:22Z

Checklist

make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
commit message follows commit guidelines

Affected core subsystem(s)

deps

Description of change

Original commit message:

[build] Add force_dynamic_crt option to build a static library with /…
…MD on windows

Adds option to build a V8 library statically, but with the options on
windows that allows it to be subsequently included in another DLL. On
Windows this is required for it to correclty link against the correct
C++ runtime. Require for our Node.js shared library build.

Reference: #7487

BUG=
R=machenbach@chromium.org, michael_dawson@ca.ibm.com

Committed: https://crrev.com/9cf88c1c364cf76c1e745aa63196768435e8ef5d
Review-Url: https://codereview.chromium.org/2149963002
Cr-Original-Commit-Position: refs/heads/master@{#37814}
Cr-Commit-Position: refs/heads/master@{#37856}

stefanmb · 2016-07-20T01:08:03Z

Required to complete work in #7487
CI: https://ci.nodejs.org/job/node-test-pull-request/3345/

Original commit message: [build] Add force_dynamic_crt option to build a static library with /… …MD on windows Adds option to build a V8 library statically, but with the options on windows that allows it to be subsequently included in another DLL. On Windows this is required for it to correclty link against the correct C++ runtime. Require for our Node.js shared library build. Reference: nodejs#7487 BUG= R=machenbach@chromium.org, michael_dawson@ca.ibm.com Committed: https://crrev.com/9cf88c1c364cf76c1e745aa63196768435e8ef5d Review-Url: https://codereview.chromium.org/2149963002 Cr-Original-Commit-Position: refs/heads/master@{nodejs#37814} Cr-Commit-Position: refs/heads/master@{nodejs#37856}

bnoordhuis · 2016-07-20T07:28:14Z

LGTM. V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/222/

bnoordhuis · 2016-07-20T07:30:05Z

Node CI again too, previous one failed massively due to network errors: https://ci.nodejs.org/job/node-test-pull-request/3347/

mhdawson · 2016-08-04T15:32:27Z

LGTM, will land today.

Original commit message: [build] Add force_dynamic_crt option to build a static library with /… …MD on windows Adds option to build a V8 library statically, but with the options on windows that allows it to be subsequently included in another DLL. On Windows this is required for it to correclty link against the correct C++ runtime. Require for our Node.js shared library build. Reference: #7487 BUG= R=machenbach@chromium.org, michael_dawson@ca.ibm.com Committed: https://crrev.com/9cf88c1c364cf76c1e745aa63196768435e8ef5d Review-Url: https://codereview.chromium.org/2149963002 Cr-Original-Commit-Position: refs/heads/master@{#37814} Cr-Commit-Position: refs/heads/master@{#37856} PR-URL: #7802 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

mhdawson · 2016-08-04T17:09:22Z

Landed as cc18937

Added "dll" option to vcbuild.bat Insure that Unix SO name is not used on Windows (i.e. produce a .dll file) Insure that Node and its V8 dependency link against the Visual C++ Runtime dynamically. Requires backported V8 patch, see PR 7802. Ref: #7802 PR-URL: #7487 Reviewed-By: Alexis Campailla <alexis@janeasystems.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

cjihrig · 2016-08-10T16:38:25Z

@stefanmb @mhdawson is this supposed to land in v6? My guess is no, but I wanted to double check.

cc: @nodejs/v8

stefanmb · 2016-08-10T17:08:36Z

@cjihrig I would say no, since we're not backporting the dependent PR: #7487.

cjihrig · 2016-08-10T17:11:23Z

OK, thanks. Adding the "don't land on" labels.

mhdawson · 2016-08-11T17:51:28Z

I'd like it to land on 6.x for our use and I believe other consumers like electron may want that as well.

@sxa555 can you backport #7487. to 6.X so that we have the pre-reqs to land this on 6.x

I think we should hold off on 4.x until we have testing etc. in place, but I do think we want in the next LTS to go out.

I'll remove the dont-land-on-v6.x, let me know if anybody disagress.

cjihrig · 2016-08-11T19:24:17Z

I'm going to reapply the dont-land-on-v6.x label, because this doesn't apply cleanly. We can use a backport PR instead.

ofrobots · 2016-08-11T20:29:39Z

I have included this commit in #8054. This won't need independent backporting if that lands on v6.x.

sxa · 2016-08-12T16:54:27Z

@cjihrig I believe the only issue with the application was that the V8 version numbers were different. The modifications themselves apply ok :-) I'm creating a separate PR that will do this along with the main WIndows changes to build as a DLL (although I can take that out if the 5.1 update lands quickly as @ofrobots suggests).

Added "dll" option to vcbuild.bat Insure that Unix SO name is not used on Windows (i.e. produce a .dll file) Insure that Node and its V8 dependency link against the Visual C++ Runtime dynamically. Requires backported V8 patch, see PR 7802. Ref: nodejs#7802 PR-URL: nodejs#7487 Reviewed-By: Alexis Campailla <alexis@janeasystems.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

Original Commit Message: Added "dll" option to vcbuild.bat Insure that Unix SO name is not used on Windows (i.e. produce a .dll file) Insure that Node and its V8 dependency link against the Visual C++ Runtime dynamically. Requires backported V8 patch, see PR 7802. Ref: #7802 PR-URL: #7487 Reviewed-By: Alexis Campailla <alexis@janeasystems.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: #8084 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>

Original commit message: [build] Add force_dynamic_crt option to build a static library with /… …MD on windows Adds option to build a V8 library statically, but with the options on windows that allows it to be subsequently included in another DLL. On Windows this is required for it to correclty link against the correct C++ runtime. Require for our Node.js shared library build. Reference: nodejs#7487 BUG= R=machenbach@chromium.org, michael_dawson@ca.ibm.com Committed: https://crrev.com/9cf88c1c364cf76c1e745aa63196768435e8ef5d Review-Url: https://codereview.chromium.org/2149963002 Cr-Original-Commit-Position: refs/heads/master@{nodejs#37814} Cr-Commit-Position: refs/heads/master@{nodejs#37856} PR-URL: nodejs#7802 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

MylesBorins · 2016-11-15T00:25:46Z

why did this backport move the change from common.gypi to toolchain.gypi?

Added "dll" option to vcbuild.bat Ensure that Unix SO name is not used on Windows (i.e. produce a .dll file) Ensure that Node and its V8 dependency link against the Visual C++ Runtime dynamically. Requires backported V8 patch Ref: nodejs#7802 PR-URL: nodejs#7487 Reviewed-By: Alexis Campailla <alexis@janeasystems.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

Original commit message: [build] Add force_dynamic_crt option to build a static library with /… …MD on windows Adds option to build a V8 library statically, but with the options on windows that allows it to be subsequently included in another DLL. On Windows this is required for it to correclty link against the correct C++ runtime. Require for our Node.js shared library build. Reference: nodejs#7487 BUG= R=machenbach@chromium.org, michael_dawson@ca.ibm.com Committed: https://crrev.com/9cf88c1c364cf76c1e745aa63196768435e8ef5d Review-Url: https://codereview.chromium.org/2149963002 Cr-Original-Commit-Position: refs/heads/master@{nodejs#37814} Cr-Commit-Position: refs/heads/master@{nodejs#37856} Ref: nodejs#7802 Ref: nodejs#8084 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

Original commit message: [build] Add force_dynamic_crt option to build a static library with /… …MD on windows Adds option to build a V8 library statically, but with the options on windows that allows it to be subsequently included in another DLL. On Windows this is required for it to correclty link against the correct C++ runtime. Require for our Node.js shared library build. Reference: #7487 BUG= R=machenbach@chromium.org, michael_dawson@ca.ibm.com Committed: https://crrev.com/9cf88c1c364cf76c1e745aa63196768435e8ef5d Review-Url: https://codereview.chromium.org/2149963002 Cr-Original-Commit-Position: refs/heads/master@{#37814} Cr-Commit-Position: refs/heads/master@{#37856} Ref: #7802 Ref: #8084 PR-URL: #9610 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>

Original Commit Message: Added "dll" option to vcbuild.bat Insure that Unix SO name is not used on Windows (i.e. produce a .dll file) Insure that Node and its V8 dependency link against the Visual C++ Runtime dynamically. Requires backported V8 patch, see PR 7802. Ref: #7802 PR-URL: #7487 Reviewed-By: Alexis Campailla <alexis@janeasystems.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: #9385 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>

stefanmb added the v8 engine Issues and PRs related to the V8 dependency. label Jul 20, 2016

stefanmb self-assigned this Jul 20, 2016

stefanmb changed the title ~~: cherry-pick 6f68f30 from v8 upstream~~ deps: cherry-pick 6f68f30 from v8 upstream Jul 20, 2016

stefanmb force-pushed the cherry-pick-v8-6f68f30 branch from 0917e78 to e93720d Compare July 20, 2016 01:08

stefanmb mentioned this pull request Jul 20, 2016

build: windows sharedlib support #7487

Closed

2 tasks

mhdawson closed this Aug 4, 2016

stefanmb added dont-land-on-v5.x and removed dont-land-on-v4.x labels Aug 5, 2016

cjihrig mentioned this pull request Aug 8, 2016

v6.4.0 Release Proposal #8020

Closed

cjihrig added dont-land-on-v5.x labels Aug 10, 2016

mhdawson removed the dont-land-on-v6.x label Aug 11, 2016

cjihrig added the dont-land-on-v6.x label Aug 11, 2016

sxa mentioned this pull request Aug 12, 2016

Backport support for building as DLL on Windows to V6 #8084

Closed

2 tasks

evanlucas mentioned this pull request Aug 26, 2016

2016-08-26, Version 6.5.0 (Current) #8253

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps: cherry-pick 6f68f30 from v8 upstream #7802

deps: cherry-pick 6f68f30 from v8 upstream #7802

stefanmb commented Jul 20, 2016

stefanmb commented Jul 20, 2016

bnoordhuis commented Jul 20, 2016

bnoordhuis commented Jul 20, 2016

mhdawson commented Aug 4, 2016

mhdawson commented Aug 4, 2016

cjihrig commented Aug 10, 2016

stefanmb commented Aug 10, 2016

cjihrig commented Aug 10, 2016

mhdawson commented Aug 11, 2016

cjihrig commented Aug 11, 2016

ofrobots commented Aug 11, 2016

sxa commented Aug 12, 2016

MylesBorins commented Nov 15, 2016

deps: cherry-pick 6f68f30 from v8 upstream #7802

deps: cherry-pick 6f68f30 from v8 upstream #7802

Conversation

stefanmb commented Jul 20, 2016

Checklist

Affected core subsystem(s)

Description of change

stefanmb commented Jul 20, 2016

bnoordhuis commented Jul 20, 2016

bnoordhuis commented Jul 20, 2016

mhdawson commented Aug 4, 2016

mhdawson commented Aug 4, 2016

cjihrig commented Aug 10, 2016

stefanmb commented Aug 10, 2016

cjihrig commented Aug 10, 2016

mhdawson commented Aug 11, 2016

cjihrig commented Aug 11, 2016

ofrobots commented Aug 11, 2016

sxa commented Aug 12, 2016

MylesBorins commented Nov 15, 2016