Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more specific README URLs to io.js, keeping node in too #80

Closed
wants to merge 8 commits into from
Closed

Adding more specific README URLs to io.js, keeping node in too #80

wants to merge 8 commits into from

Conversation

imjacobclark
Copy link

I have updated the readme and created the two Wiki pages for Community and Contributing, using the CONTRIBUTING.md and the Node Community Wiki as a template.

@imjacobclark imjacobclark changed the title Updating readme URLs to io.js Adding more specific URLs to io.js, keeping node in too Dec 5, 2014
@imjacobclark imjacobclark changed the title Adding more specific URLs to io.js, keeping node in too Adding more specific README URLs to io.js, keeping node in too Dec 5, 2014
- [nodejs.org](http://nodejs.org/)
- [how to install node.js and npm (node package manager)](http://www.joyent.com/blog/installing-node-and-npm/)
- [list of modules](https://github.com/joyent/node/wiki/modules)
- [list of node modules](https://github.com/joyent/node/wiki/modules)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1 the ecosystem should be shared :(

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, agreed. I was trying to be specific to where you were being linked however it does appear to give that impression.

Fixed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay, good to see your changes 🍒

@imjacobclark imjacobclark mentioned this pull request Dec 5, 2014
- [node community](https://github.com/joyent/node/wiki/Community)
- [io.js contributing](https://github.com/io.js/iojs/wiki/Contributing)
- [big list of all the helpful node wiki pages](https://github.com/joynet/node/wiki/_pages)
- [big list of all the helpful io.js wiki pages](https://github.com/io.js/iojs/wiki/_pages)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: put io.js-based resources above their node.js equivalents?

@imjacobclark
Copy link
Author

Closing as no longer relevant.

jianchun referenced this pull request in nodejs/node-chakracore Dec 2, 2015
"supportsOverrideToString" was originally added to make old
FastBuffer work. Buffer has long changed implementation. This is
no longer used.

Fix #80

Reviewed-by: @kunalspathak
jianchun referenced this pull request in nodejs/node-chakracore Dec 7, 2015
"supportsOverrideToString" was originally added to make old FastBuffer
work. Buffer has long switched to TypedArray implementation. This is no
longer used.

Fix #80

Reviewed-by: @kunalspathak
rvagg pushed a commit to nodejs/TSC that referenced this pull request Jun 14, 2016
PR-URL: nodejs/node#80
Reviewed-By: Rod Vagg <rod@vagg.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants