Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: favor strict equality check #8130

Closed
wants to merge 1 commit into from
Closed

test: favor strict equality check #8130

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 16, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test tls

Description of change

Change use of != in assertion to assert.notStrictEqual() check.

@Trott
test: favor strict equality check
e42d90d 
Change use of `!=` in assertion to `assert.notStrictEqual()` check.
@Trott Trott added tls Issues and PRs related to the tls subsystem. test Issues and PRs related to the tests. labels Aug 16, 2016
@addaleax
Copy link
Member

LGTM, CI: https://ci.nodejs.org/job/node-test-commit/4609/

@targos
Copy link
Member

targos commented Aug 17, 2016

LGTM

1 similar comment
@jasnell
Copy link
Member

jasnell commented Aug 17, 2016

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Aug 18, 2016
@Trott
test: favor strict equality check
7652ae9 
Change use of `!=` in assertion to `assert.notStrictEqual()` check.

PR-URL: nodejs#8130
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Copy link
Member Author

Trott commented Aug 18, 2016

Landed in 7652ae9

@Trott Trott closed this Aug 18, 2016
evanlucas pushed a commit that referenced this pull request Aug 24, 2016
@Trott @evanlucas
test: favor strict equality check
086e57f 
Change use of `!=` in assertion to `assert.notStrictEqual()` check.

PR-URL: #8130
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@evanlucas evanlucas mentioned this pull request Aug 24, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
@Trott
test: favor strict equality check
a194574 
Change use of `!=` in assertion to `assert.notStrictEqual()` check.

PR-URL: #8130
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
@Trott @rvagg
test: favor strict equality check
345e272 
Change use of `!=` in assertion to `assert.notStrictEqual()` check.

PR-URL: #8130
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
@Trott @MylesBorins
test: favor strict equality check
af02d2a 
Change use of `!=` in assertion to `assert.notStrictEqual()` check.

PR-URL: #8130
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
Closed
@Trott Trott deleted the memleak branch January 13, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @addaleax @targos @jasnell @MylesBorins