test: test sending over a closed IPC channel #8160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
added
the
child_process
|
LGTM if CI is green |
|
LGTM |
This commit adds a test that attempts to send data over an IPC channel once it has been closed. PR-URL: nodejs#8160 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
evanlucas
pushed a commit
that referenced
this pull request
Aug 24, 2016
This commit adds a test that attempts to send data over an IPC channel once it has been closed. PR-URL: #8160 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
|
This test is failing when backported to v4.x Adding don't land label. Feel free to let me know if something needs to be backported |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
This commit adds a test that attempts to send data over an IPC channel once it has been closed.