build: add node_module_version to config.gypi #8171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
build
saper
force-pushed
the
node_module_version/v4.x
branch
from
47ad258 to
ce1bf24
Compare
saper
force-pushed
the
node_module_version/v4.x
branch
from
ce1bf24 to
adc09c7
Compare
Enable targetting of a different node version than the currently running one when building binary modules. Based on nodejs/node@410296c37 PR-URL: nodejs#8171 Ref: nodejs#8027 Ref: nodejs#7808 Ref: nodejs/node-gyp#855
saper
force-pushed
the
node_module_version/v4.x
branch
from
adc09c7 to
7b8b8d4
Compare
|
LGTM |
1 similar comment
|
LGTM |
| @@ -769,6 +769,8 @@ def configure_node(o): | |||
| if options.enable_static: | |||
| o['variables']['node_target_type'] = 'static_library' | |||
|
|
|||
| o['variables']['node_module_version'] = 46 | |||
There was a problem hiding this comment.
Should probable be added to release docs:
https://github.com/nodejs/node/blob/master/doc/releases.md#2-update-srcnode_versionh
There was a problem hiding this comment.
Nevermind, I see it's autogenerated on master already.
|
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Aug 22, 2016
Enable targetting of a different node version than the currently running one when building binary modules. Based on 410296c37 PR-URL: #8171 Ref: #8027 Ref: #7808 Ref: nodejs/node-gyp#855 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
|
Landed in v4.x-staging in a0a1de1. Thank you! |
|
thanks! 🚀 |
MylesBorins
pushed a commit
that referenced
this pull request
Sep 28, 2016
Enable targetting of a different node version than the currently running one when building binary modules. Based on 410296c37 PR-URL: #8171 Ref: #8027 Ref: #7808 Ref: nodejs/node-gyp#855 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
rvagg
pushed a commit
that referenced
this pull request
Oct 18, 2016
Enable targetting of a different node version than the currently running one when building binary modules. Based on 410296c37 PR-URL: #8171 Ref: #8027 Ref: #7808 Ref: nodejs/node-gyp#855 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 26, 2016
Enable targetting of a different node version than the currently running one when building binary modules. Based on 410296c37 PR-URL: #8171 Ref: #8027 Ref: #7808 Ref: nodejs/node-gyp#855 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable targetting of a different node version than
the currently running one when building binary modules.
Based on 410296c37
Ref: #8027
Ref: #7808
Ref: nodejs/node-gyp#855