test: change equals comparison operator to be strict #8190
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nit: Can you shorten the first line of the commit message so that it is 50 chars or less? |
Trott
added
the
timers
thecoolestguy
force-pushed
the
comparison_operator_cleanup
branch
2 times, most recently
from
c490cbf to
f78f1b5
Compare
The 'equals' comparison operator was '==' instead of the more strict '===', so it has been changed to be more strict
thecoolestguy
force-pushed
the
comparison_operator_cleanup
branch
from
f78f1b5 to
45d1612
Compare
|
LGTM if CI is green. |
|
LGTM |
1 similar comment
|
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Aug 22, 2016
The 'equals' comparison operator was '==' instead of the more strict '===', so it has been changed to be more strict PR-URL: #8190 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in d904163. Thank you! |
evanlucas
pushed a commit
that referenced
this pull request
Aug 24, 2016
The 'equals' comparison operator was '==' instead of the more strict '===', so it has been changed to be more strict PR-URL: #8190 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Description of change
The 'equals' comparison operator was '==' instead of the more strict '===', so it has been changed to be more strict.