Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: favor === over == in vm test #8191

Closed
wants to merge 1 commit into from
Closed

test: favor === over == in vm test #8191

wants to merge 1 commit into from

Conversation

jun-oka
Copy link
Contributor

@jun-oka jun-oka commented Aug 19, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test vm

Description of change

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 19, 2016
@Trott Trott added the vm Issues and PRs related to the vm subsystem. label Aug 19, 2016
@Trott
Copy link
Member

Trott commented Aug 19, 2016

LGTM if CI is green.

CI: https://ci.nodejs.org/job/node-test-pull-request/3758/

@addaleax
Copy link
Member

Looks good to me!

@MylesBorins
Copy link
Contributor

LGTM

o/ @jun-oka

@cjihrig
Copy link
Contributor

cjihrig commented Aug 19, 2016

LGTM

@Trott
Copy link
Member

Trott commented Aug 19, 2016

CI is green, not sure why the widget hasn't updated?

@addaleax
Copy link
Member

@Trott might be because we had a race condition, I started https://ci.nodejs.org/job/node-test-pull-request/3757/ but aborted that one when I read that you already had commented here with https://ci.nodejs.org/job/node-test-pull-request/3758/ :)

@jbergstroem
Copy link
Member

LGTM

1 similar comment
@jasnell
Copy link
Member

jasnell commented Aug 19, 2016

LGTM

@jun-oka
Copy link
Contributor Author

jun-oka commented Aug 20, 2016

Thank you for the comments All ! :)

(^O^)／@thealphanerd

@fhinkel
Copy link
Member

fhinkel commented Aug 21, 2016

LGTM

fhinkel pushed a commit to fhinkel/node that referenced this pull request Aug 21, 2016
@jun-oka @fhinkel
test: favor === over == in vm test
ce8753a 
PR-URL: nodejs#8191
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: jbergstroem - Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@fhinkel
Copy link
Member

fhinkel commented Aug 21, 2016

Thanks! Landed in ce8753a.

@fhinkel fhinkel closed this Aug 21, 2016
evanlucas pushed a commit that referenced this pull request Aug 24, 2016
@jun-oka @evanlucas
test: favor === over == in vm test
b8f5a2b 
PR-URL: #8191
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: jbergstroem - Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@evanlucas evanlucas mentioned this pull request Aug 24, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test Issues and PRs related to the tests. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@jun-oka @Trott @addaleax @MylesBorins @cjihrig @jbergstroem @jasnell @fhinkel @nodejs-github-bot