test: refactor test-timers-linked-list.js #8193
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* check that empty linked lists have identical properties * `assert.equal()` -> `assert.strictEqual()` * `var` -> `const`
Trott
added
timers
|
lgtm |
|
LGTM |
2 similar comments
|
LGTM |
|
LGTM |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Aug 23, 2016
* check that empty linked lists have identical properties * `assert.equal()` -> `assert.strictEqual()` * `var` -> `const` PR-URL: nodejs#8193 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
|
Known flaky failures only. Landed in 1aa47d8 |
evanlucas
pushed a commit
that referenced
this pull request
Aug 24, 2016
* check that empty linked lists have identical properties * `assert.equal()` -> `assert.strictEqual()` * `var` -> `const` PR-URL: #8193 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test timers
Description of change
assert.equal()->assert.strictEqual()var->const