-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
buffer: expose underlying buffer object always #8311
Conversation
If the Buffer object's length is zero, or equal to the underlying buffer object's length, `parent` property returns `undefined`. > new Buffer(0).parent undefined > new Buffer(Buffer.poolSize).parent undefined This patch makes the buffer objects to consistently expose the buffer object via the `parent` property, always. Fixes: nodejs#8266
LGTM. Though can we also move to deprecate |
LGTM … what do you think on the semver-ness of this? It doesn’t seem like something that would reasonably break anybody’s code, but it does involve having to change the existing tests. CI: https://ci.nodejs.org/job/node-test-commit/4812/ |
CI looks okay, for CITGM… @thealphanerd are those known failures? (Also… so many |
+1 to a runtime deprecation on |
LGTM |
@thefourtheye This is good to go, right? :) |
@addaleax I would say so, as I have seen the vinyl-fs failure in few other runs as well. I thought it would be better if @thealphanerd or @phated could give GO/NO-GO here. |
Pretty sure these are permission problems and the citgm needs to be fixed. |
+1 to getting this landed :-) |
Landed in c21458a |
If the Buffer object's length is zero, or equal to the underlying buffer object's length, `parent` property returns `undefined`. > new Buffer(0).parent undefined > new Buffer(Buffer.poolSize).parent undefined This patch makes the buffer objects to consistently expose the buffer object via the `parent` property, always. Fixes: #8266 PR-URL: #8311 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Getting this trying to land on v6-staging:
|
Checklist
make -j4 test
(UNIX), orvcbuild test nosign
(Windows) passesAffected core subsystem(s)
buffer
Description of change
If the Buffer object's length is zero, or equal to the underlying
buffer object's length,
parent
property returnsundefined
.This patch makes the buffer objects to consistently expose the buffer
object via the
parent
property, always.Fixes: #8266
cc @nodejs/buffer